Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix BitstreamConverter missing declarations #11670

Merged
merged 1 commit into from Feb 14, 2017

Conversation

@peak3d
Copy link
Contributor

commented Feb 14, 2017

[AML] Compile Fix BitsreamConverter

Description

see title

@peak3d peak3d merged commit c3ea113 into xbmc:master Feb 14, 2017
0 of 2 checks passed
0 of 2 checks passed
continuous-integration/appveyor/pr Waiting for AppVeyor build to complete
Details
continuous-integration/travis-ci/pr The Travis CI build is in progress
Details
@peak3d peak3d referenced this pull request Feb 14, 2017
3 of 9 tasks complete
@MartijnKaijser MartijnKaijser added this to the L 18.0-alpha1 milestone Feb 14, 2017
@@ -87,8 +87,8 @@ class CBitstreamParser
CBitstreamParser();
~CBitstreamParser();

static bool Open();
static void Close();
static bool Open(){};

This comment has been minimized.

Copy link
@tamland

tamland Feb 28, 2017

Member

@peak3d You forgot to return. If called, this is undefined behaviour. It's a good idea enable -Werror=return-type to catch these types of errors..

@peak3d

This comment has been minimized.

Copy link
Contributor Author

commented Mar 1, 2017

Thank you, will fix, @tamland

#11784

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.