Join GitHub today
[xbmc] Start work on getting rid of our emulated GetDiskFreeSpaceEx method #11741
Decided to unify some of our low level file handling
Motivation and Context
How Has This Been Tested?
runtime tested on windows
Screenshots (if appropriate):
Types of change
Decided to unify some of our low level file handling methods on the std::filesystem idea. As it's not standardized yet and implementations are experimental this is a simple version that suits our current needs. The idea is that once platforms start offering non-experimental versions of std::filesytem we can easily move over to using them.
1 similar comment
Our storage provider is a bit higher in the hierarchy for what I want to achieve with the filesystem methods, intending to implement stat and possibly the directory iterators so we have a common low level abstraction and can reduce some ifdefs.
Using storage manager for the sysinfo might be a good idea, will have a look at it and see.
Fixed the invalid test for TARGET_BSD / TARGET_DARWIN
Dropped the counting of "total" space on win32 as it's a useless metric, added some comments but kept the GetDiskspaceInfo method for backward compat with skins that rely on it.
jenkins build this please