Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Fix]Speedup Songs node by skipping pointless fetch of cuesheet data #11785

Merged
merged 1 commit into from Mar 3, 2017

Conversation

Projects
None yet
2 participants
@DaveTBlake
Copy link
Member

commented Mar 1, 2017

Chipping away at what makes songs node on large library so slow.

The way embedded cueshseets are implemented is taking 7% of the total time taken to process the songs node, even when there are no embedded cuesheets in the music collection. Even worse the cuesheet processing in GetSongsFullByWhere() is only to get replay gain data for any embedded cuesheets, yet other design flaws means that this replay gain is not actually applied on playback. Not only is the way the data is fetched inefficient, but it is totally pointless!

It is a minor change to stop fetching embedded cuesheet replay gain data by default, and I suggest we backport it for an immediate performance gain.

I am looking at fixing the cuesheet data design and replaygain issues for Leia in a separate PR.

@Paxxi

Paxxi approved these changes Mar 1, 2017

@Paxxi Paxxi modified the milestones: L 18.0-alpha1, Krypton 17.1-RC2 Mar 1, 2017

@DaveTBlake

This comment has been minimized.

Copy link
Member Author

commented Mar 1, 2017

jenkins build this please

@DaveTBlake

This comment has been minimized.

Copy link
Member Author

commented Mar 1, 2017

Jenkins fail is libavcode issue, nothing to do with this PR.

Looks like embedded cuesheets have been broken by the unification of music lib and file views #8011 back in Jarvis. Not only is the lib data ignored, but when not in the lib play from file view results in a corrupted current playlist

@DaveTBlake DaveTBlake merged commit 1af50b2 into xbmc:master Mar 3, 2017

2 of 3 checks passed

jenkins4kodi You are a failure. Fix the code and try again......
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@DaveTBlake DaveTBlake deleted the DaveTBlake:NoCuesheets branch Mar 3, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.