Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace deprecated glibc aliases. #11821

Merged
merged 1 commit into from Mar 7, 2017

Conversation

@stintel
Copy link
Contributor

commented Mar 7, 2017

Description

MNTTAB and MOUNTED are deprecated aliases. Replace them with
_PATH_MNTTAB and _PATH_MOUNTED.

Motivation and Context

Following https://www.gnu.org/software/libc/manual/html_node/Mount-Information.html, the deprecated names should not be used. This is also required for compatibility with musl libc.

How Has This Been Tested?

On glibc and uClibc this change is a noop, but compile-tested against glibc anyway.

Types of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the Code guidelines of this project
  • My change requires a change to the documentation, either Doxygen or wiki
  • I have updated the documentation accordingly
  • I have read the CONTRIBUTING document
  • I have added tests to cover my change
  • All new and existing tests passed
MNTTAB and MOUNTED are deprecated aliases. Replace them with
_PATH_MNTTAB and _PATH_MOUNTED.

Signed-off-by: Stijn Tintel <stijn@linux-ipv6.be>
@Paxxi

This comment has been minimized.

Copy link
Member

commented Mar 7, 2017

Thank you. @wsnipex your thoughts?

@wsnipex

This comment has been minimized.

Copy link
Member

commented Mar 7, 2017

looks good.
on an related note: I wonder if we'll ever get rid of the win emu layers..

@wsnipex

This comment has been minimized.

Copy link
Member

commented Mar 7, 2017

jenkins build this please

@Paxxi

This comment has been minimized.

Copy link
Member

commented Mar 7, 2017

I'm working on it, currently it's only used by libdvd, once that's fixed we can drop it all

@wsnipex wsnipex merged commit 1174011 into xbmc:master Mar 7, 2017
3 checks passed
3 checks passed
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
jenkins4kodi You did a great job. Have a cookie.
Details
@Rechi Rechi added the v18 Leia label Mar 7, 2017
@Rechi Rechi added this to the L 18.0-alpha1 milestone Mar 7, 2017
@stintel stintel deleted the stintel:glibc_deprecated branch Mar 21, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.