Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[depends] libfmt: remove BASE_URL pointing to github #11830

Merged
merged 2 commits into from Mar 9, 2017

Conversation

@Montellese
Copy link
Member

commented Mar 8, 2017

I just realized that I uploaded the win32 deps archive but not the one for depends builds and that the Makefile still pointed to github. I have uploaded fmt-3.0.1.tar.gz to our mirrors.

@Montellese Montellese added this to the L 18.0-alpha1 milestone Mar 8, 2017

@Montellese Montellese requested a review from wsnipex Mar 8, 2017

@wsnipex

This comment has been minimized.

Copy link
Member

commented Mar 8, 2017

I assume fmt-3.0.0.tar.gz is a typo, since you uploaded http://mirrors.kodi.tv/build-deps/sources/fmt-3.0.1.tar.gz

as noted in #11039 (comment) can you please add CMAKE_INSTALL_PREFIX for the native compile case? e.g. on L25

@Montellese

This comment has been minimized.

Copy link
Member Author

commented Mar 9, 2017

Yeah sorry, fmt-3.0.1.tar.gz as also used in the Makefile. I've added the extra line. Is it ok like this?
jenkins build this please.

@wsnipex
wsnipex approved these changes Mar 9, 2017

@Montellese Montellese merged commit 5211531 into xbmc:master Mar 9, 2017

3 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
jenkins4kodi You did a great job. Have a cookie.
Details

@Montellese Montellese deleted the Montellese:fmt_fix_depends branch Mar 9, 2017

@Rechi Rechi added the v18 Leia label Mar 9, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.