Return more accurate information about SampleRate #1193

Merged
1 commit merged into from Aug 3, 2012

Conversation

Projects
None yet
2 participants
@Karlson2k
Member

Karlson2k commented Jul 21, 2012

After #1165 we loose some accuracy about Sample Rate when it's 44100, 22050 and so on.
This patch returns accuracy back.

@Karlson2k

This comment has been minimized.

Show comment Hide comment
@Karlson2k

Karlson2k Jul 21, 2012

Member

@cptspiff as you recomend

Member

Karlson2k commented Jul 21, 2012

@cptspiff as you recomend

@jmarshallnz

This comment has been minimized.

Show comment Hide comment
@jmarshallnz

jmarshallnz Jul 21, 2012

Collaborator

You probably want to use %f rather than %g.

Collaborator

jmarshallnz commented on d224ce5 Jul 21, 2012

You probably want to use %f rather than %g.

This comment has been minimized.

Show comment Hide comment
@Karlson2k

Karlson2k Jul 22, 2012

Owner

I think that %g is better than %f as it skips any trailing zeros.
So we get 48 kHz, 44.1 kHz, 22.05 kHz and not 48.0, 44.1 and 22.1 or 48.00.
At the same time with all real possible rates we'll never get something like 12e+6 kHz. :)

Owner

Karlson2k replied Jul 22, 2012

I think that %g is better than %f as it skips any trailing zeros.
So we get 48 kHz, 44.1 kHz, 22.05 kHz and not 48.0, 44.1 and 22.1 or 48.00.
At the same time with all real possible rates we'll never get something like 12e+6 kHz. :)

@Karlson2k

This comment has been minimized.

Show comment Hide comment
@Karlson2k

Karlson2k Jul 29, 2012

Member

@jmarshallnz , @cptspiff
Is it ok to go?

Member

Karlson2k commented Jul 29, 2012

@jmarshallnz , @cptspiff
Is it ok to go?

@Karlson2k

This comment has been minimized.

Show comment Hide comment
@Karlson2k

Karlson2k Aug 1, 2012

Member

@jmarshallnz Is it time to go?

Member

Karlson2k commented Aug 1, 2012

@jmarshallnz Is it time to go?

ghost pushed a commit that referenced this pull request Aug 3, 2012

Arne Morten Kvarving
Merge pull request #1193 from Karlson2k/Khz_with_decimal
Return more accurate information about SampleRate

@ghost ghost merged commit b343bb2 into xbmc:master Aug 3, 2012

tru added a commit to plexinc/plex-home-theater-public that referenced this pull request May 19, 2014

tru added a commit to RasPlex/plex-home-theatre that referenced this pull request Aug 21, 2014

This issue was closed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment