Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[windows] installer: call findstr with full path #11940

Merged
merged 1 commit into from Apr 9, 2017

Conversation

@Rechi
Copy link
Member

commented Apr 8, 2017

Description

Also call findstr with full path (%SYSTEMROOT%\System32\findstr.exe)

Motivation and Context

User doesn't have %SYSTEMROOT%\System32 in PATH environment variable.

Types of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the Code guidelines of this project
  • My change requires a change to the documentation, either Doxygen or wiki
  • I have updated the documentation accordingly
  • I have read the CONTRIBUTING document
  • I have added tests to cover my change
  • All new and existing tests passed
@Rechi Rechi added this to the L 18.0-alpha1 milestone Apr 8, 2017
@Rechi Rechi referenced this pull request Apr 8, 2017
3 of 9 tasks complete
@Rechi Rechi merged commit d67cbb8 into xbmc:master Apr 9, 2017
1 of 2 checks passed
1 of 2 checks passed
continuous-integration/travis-ci/pr The Travis CI build could not complete due to an error
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
@Rechi Rechi deleted the Rechi:fixWinSetupKB branch Apr 9, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
1 participant
You can’t perform that action at this time.