Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable middle mouse button on embedded platform #11956

Merged
merged 2 commits into from Apr 16, 2017

Conversation

@pablopoo
Copy link
Contributor

pablopoo commented Apr 12, 2017

Right now a mouse middle button click triggers a XBMC right click, not a XBMC middle click.

Description

Changed:

case BTN_MIDDLE:
devt.button.button = XBMC_BUTTON_RIGHT;
break;

to

case BTN_MIDDLE:
devt.button.button = XBMC_BUTTON_MIDDLE;
break;

so a BTN_MIDDLE is mapped to XBMC_BUTTON_MIDDLE

Motivation and Context

I use the BTN_MIDDLE event on the Raspberry Pi with a Griffin Powermate USB (dial + push button), emulating a mouse wheel with a middle button.

How Has This Been Tested?

Patched Libreelec 8.0.1 and tested on a Raspberry Pi.

Screenshots (if appropriate):

Types of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the Code guidelines of this project
  • My change requires a change to the documentation, either Doxygen or wiki
  • I have updated the documentation accordingly
  • I have read the CONTRIBUTING document
  • I have added tests to cover my change
  • All new and existing tests passed
pablopoo added 2 commits Apr 12, 2017
Right now a mouse middle button click triggers a XBMC right click, not a XBMC middle click.
…ick-1

Enable middle mouse button on embedded platform
@Razzeee

This comment has been minimized.

Copy link
Member

Razzeee commented Apr 14, 2017

Thanks!

That code has been there for 6 years, but maybe @MrMC remembers anyway?

@pablopoo

This comment has been minimized.

Copy link
Contributor Author

pablopoo commented Apr 14, 2017

@Razzeee @MrMC,I searched on some mirrors of the old repo and here, but didn't found any reason on why middle click was set that way.

@ghost

This comment has been minimized.

Copy link

ghost commented Apr 14, 2017

Not a clue why I had it that way. Too long ago. I suspect it was related to either Sigma or Linux for Tegra ports as original ATV/iOS ports did not use it.

@Razzeee

This comment has been minimized.

Copy link
Member

Razzeee commented Apr 14, 2017

So let's merge this and keep our eyes open for regressions

@Razzeee

This comment has been minimized.

Copy link
Member

Razzeee commented Apr 14, 2017

jenkins build this please

@Razzeee Razzeee merged commit ec888ea into xbmc:master Apr 16, 2017
2 of 3 checks passed
2 of 3 checks passed
continuous-integration/travis-ci/pr The Travis CI build could not complete due to an error
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
jenkins4kodi You did a great job. Have a cookie.
Details
@Rechi Rechi added this to the L 18.0-alpha1 milestone Apr 16, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.