[network][windows] GetNameServers(): use GetAdaptersAddresses #11995
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… of GetNetworkParams
Rechi
added
Type: Feature
Paxxi
reviewed
Apr 21, 2017
| switch (sa->sa_family) | ||
| { | ||
| case AF_INET: | ||
| RtlIpv4AddressToStringA(&reinterpret_cast<const struct sockaddr_in *>(sa)->sin_addr, buffer); |
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
|
@MartijnKaijser @Paxxi In my Windows 10 UWP version, TARGET_WIN10 will use different code in xbmc/network/windowsstore/NetworkWin10.cpp. There are too many unsupported Win32 APIs in NetworkWin32.cpp. Any changes to NetworkWin32.cpp will not affect the UWP version. |
|
@Paxxi as this file isn't currently used in the UWP development version can this get merged? |
|
jenkins build and merge |
1 similar comment
|
jenkins build and merge |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Use
GetAdaptersAddressesinstead ofGetNetworkParamsto get the list of nameservers on windowsMotivation and Context
GetAdaptersAddressesalso returns IPv6 addresses ans is Windows Store compatible.How Has This Been Tested?
runtime tested
Types of change
Checklist: