Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

changed: remove internal sftp support #12005

Merged
merged 1 commit into from Jun 20, 2018

Conversation

Projects
None yet
8 participants
@notspiff
Copy link
Contributor

commented Apr 24, 2017

This removes the internal sftp support, ref xbmc/repo-binary-addons#82 and https://github.com/notspiff/vfs.sftp

Note this raises the question what to do with the network source setup dialog. I have opted to show the sftp entry unconditionally right now.

@MartijnKaijser

This comment has been minimized.

Copy link
Member

commented Apr 24, 2017

Perhaps it should be shown if the addon is present on the system. If the add-on is disabled it asks to enable it?

@notspiff

This comment has been minimized.

Copy link
Contributor Author

commented Apr 24, 2017

yes. that is certainly an option. but that requires some language for the add-ons to specify what its protocol support.

@Rechi

This comment has been minimized.

Copy link
Member

commented Apr 24, 2017

tools/depends/target/libssh can also be removed

@notspiff

This comment has been minimized.

Copy link
Contributor Author

commented Apr 24, 2017

good catch.

@notspiff notspiff force-pushed the notspiff:remove_sftp branch from 542e41c to 8fac9b4 Apr 24, 2017

@Rechi

This comment has been minimized.

Copy link
Member

commented Apr 24, 2017

You also have to remove libssh from tools/depends/target/Makefile otherwise building depends will fail.

edit: it can also be removed from project/BuildDependencies/scripts/0_package.target-win32.list

@notspiff

This comment has been minimized.

Copy link
Contributor Author

commented Apr 24, 2017

correct you are. using my left hand's left hand and 1% brain on this thanks for handholding ;)

@notspiff notspiff force-pushed the notspiff:remove_sftp branch 2 times, most recently from 9c3b84c to 5e13044 Apr 24, 2017

candrews added a commit to candrews/gentoo that referenced this pull request Jun 6, 2017

media-tv/kodi: remove sftp use flag on -9999 ebuild
See xbmc/xbmc#12005

Package-Manager: Portage-2.3.6, Repoman-2.3.2

candrews added a commit to candrews/gentoo that referenced this pull request Jun 6, 2017

media-plugins/kodi-vfs-sftp: SFTP VFS addon for Kodi
Adds support for RAR archives to Kodi.
This functionality was originally part of Kodi itself, but was removed in Kodi 18.

See xbmc/xbmc#12005

Package-Manager: Portage-2.3.6, Repoman-2.3.2
@candrews

This comment has been minimized.

Copy link
Contributor

commented Jun 6, 2017

bump

candrews added a commit to candrews/gentoo that referenced this pull request Jun 19, 2017

media-plugins/kodi-vfs-sftp: SFTP VFS addon for Kodi
Adds support for SFTP to Kodi.
This functionality was originally part of Kodi itself, but was removed in Kodi 18.

See xbmc/xbmc#12005

Package-Manager: Portage-2.3.6, Repoman-2.3.2
@Razzeee

This comment has been minimized.

Copy link
Member

commented Sep 16, 2017

Rebase please :)

@notspiff notspiff force-pushed the notspiff:remove_sftp branch from 5e13044 to 6be51a9 Sep 19, 2017

@notspiff

This comment has been minimized.

Copy link
Contributor Author

commented Sep 19, 2017

rebased. add-on still needs to be moved to new structure and synced with mainline code + we need to figure out what to do with the protocol support in the add network source dialog.

@Rechi

This comment has been minimized.

Copy link
Member

commented Sep 19, 2017

should also be removed

EDIT
also ssh.dll from

set(_delayloadlibs zlib.dll libmysql.dll libxslt.dll dnssd.dll dwmapi.dll ssh.dll sqlite3.dll

@notspiff

This comment has been minimized.

Copy link
Contributor Author

commented Sep 20, 2017

done. i assumed you wanted it removed for win32 as well

@xhaggi

This comment has been minimized.

Copy link
Member

commented Nov 22, 2017

@notspiff time to push this forward?

@@ -203,9 +203,7 @@ void CGUIDialogNetworkSetup::InitializeSettings()
#ifdef HAS_FILESYSTEM_NFS
labels.push_back(std::make_pair(20259, NET_PROTOCOL_NFS));
#endif
#ifdef HAS_FILESYSTEM_SFTP
labels.push_back(std::make_pair(20260, NET_PROTOCOL_SFTP));

This comment has been minimized.

Copy link
@xhaggi

xhaggi Nov 22, 2017

Member

should be dropped

@notspiff

This comment has been minimized.

Copy link
Contributor Author

commented Nov 22, 2017

need to update the add-on a little then yes. will get to asap.

@xhaggi

This comment has been minimized.

Copy link
Member

commented Nov 22, 2017

ok cool 👍

@notspiff notspiff force-pushed the notspiff:remove_sftp branch from 186084e to bf36a84 Nov 22, 2017

@notspiff

This comment has been minimized.

Copy link
Contributor Author

commented Nov 22, 2017

rebased, add-on updated, appeared to work fine in some quick tests.

@notspiff

This comment has been minimized.

Copy link
Contributor Author

commented Nov 22, 2017

@afedchin is there some (new) winstore file that needs cleaning ?

@candrews

This comment has been minimized.

Copy link
Contributor

commented Mar 6, 2018

bump

@Rechi Rechi force-pushed the notspiff:remove_sftp branch from 25c9efe to c5919ef Mar 26, 2018

@Rechi Rechi force-pushed the notspiff:remove_sftp branch from c5919ef to 3f22264 Apr 9, 2018

@candrews

This comment has been minimized.

Copy link
Contributor

commented Jun 11, 2018

@notspiff just curious on the status of this one, I'm interested in seeing it in Kodi 18

@notspiff

This comment has been minimized.

Copy link
Contributor Author

commented Jun 18, 2018

i've gotten no indications this is wanted for v18 so it is in slumber mode.

@MartijnKaijser

This comment has been minimized.

Copy link
Member

commented Jun 18, 2018

If we can switch to addon we can add it.

@notspiff notspiff force-pushed the notspiff:remove_sftp branch from e3eba5e to e48deb1 Jun 18, 2018

@notspiff notspiff force-pushed the notspiff:remove_sftp branch 2 times, most recently from 6f9735a to 11dfbc3 Jun 18, 2018

@Rechi

This comment has been minimized.

Copy link
Member

commented Jun 18, 2018

Don't know if the following language strings should be kept in core

#: unknown
msgctxt "#13020"
msgid "Is another session active, perhaps over ssh?"
msgstr ""

#: xbmc/network/GUIDialogNetworkSetup.cpp
msgctxt "#20260"
msgid "Secure Shell (SSH / SFTP)"
msgstr ""

@Rechi

Rechi approved these changes Jun 18, 2018

@notspiff notspiff force-pushed the notspiff:remove_sftp branch from 11dfbc3 to da70547 Jun 20, 2018

@Rechi Rechi added this to the Leia 18.0-alpha2 milestone Jun 20, 2018

@Rechi Rechi merged commit fb1dcb3 into xbmc:master Jun 20, 2018

1 check passed

default You're awesome. Have a cookie
Details

@Rechi Rechi added the Wiki: Needed label Jun 20, 2018

candrews added a commit to candrews/gentoo that referenced this pull request Jun 20, 2018

media-tv/kodi: remove sftp use flag on -9999 ebuild
See xbmc/xbmc#12005

Package-Manager: Portage-2.3.6, Repoman-2.3.2

candrews added a commit to candrews/gentoo that referenced this pull request Jun 20, 2018

media-plugins/kodi-vfs-sftp: SFTP VFS addon for Kodi
Adds support for SFTP to Kodi.
This functionality was originally part of Kodi itself, but was removed in Kodi 18.

See xbmc/xbmc#12005

Package-Manager: Portage-2.3.6, Repoman-2.3.2
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.