Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PVR] Another round of code cleanup #12044

Merged
merged 17 commits into from May 3, 2017
Merged
Changes from 1 commit
Commits
Show all changes
17 commits
Select commit Hold shift + click to select a range
0d4722a
[PVR] Cleanup: Remove unused class CPVRPersistGroupJob. Remove empty …
ksooo May 1, 2017
76808b3
[PVR] Cleanup: Use 'override' whenever possible. Use 'virtual' only i…
ksooo May 1, 2017
9f39bef
[PVR] Cleanup: Use '= default' and '= delete' whenever possible.
ksooo May 1, 2017
68ec6fe
[PVR] Cleanup: Remove superfluous semicolons.
ksooo May 1, 2017
43b195e
[PVR] Cleanup: CPVRClient no longer needs to be friend of CPVRClients.
ksooo May 1, 2017
ec7e698
[PVR] Cleanup: CPVRChannelGroupInternal no longer needs to be friend …
ksooo May 1, 2017
8380700
[PVR] Cleanup: CPVRChannelGroups no longer needs to be friend of CPVR…
ksooo May 1, 2017
25d753d
[PVR] Cleanup: CPVRChannelGroupsContainer no longer needs to be frien…
ksooo May 1, 2017
4fa61bb
[PVR] Cleanup: CPVRChannelGroups no longer needs to be friend of CPVR…
ksooo May 1, 2017
ba614be
[PVR] Cleanup: CPVRDatabase no longer needs to be friend of CPVRChann…
ksooo May 1, 2017
8cb1f54
[PVR] Cleanup: CPVRClients no longer needs to be friend of CPVRManager.
ksooo May 2, 2017
8a8a370
[PVR] Cleanup: CPVRTimers no longer needs to be friend of CPVRTimerIn…
ksooo May 2, 2017
0240d7b
[PVR] Cleanup: CPVRMamager no longer needs to be friend of CPVRChanne…
ksooo May 2, 2017
b140975
[PVR] Cleanup: CPVRChannelsUpdateJob no longer needs to be friend of …
ksooo May 2, 2017
bcc9143
[PVR] Cleanup: CPVRChannelGroupsUpdateJob no longer needs to be frien…
ksooo May 2, 2017
29a63ec
[PVR] Cleanup: Removed unneeded forward declarations.
ksooo May 2, 2017
ecd06bd
[PVR] Clenup: CPVRClient header (Missed this one so far as it is not …
ksooo May 2, 2017
File filter...
Filter file types
Jump to…
Jump to file or symbol
Failed to load files and symbols.

Always

Just for now

[PVR] Cleanup: Removed unneeded forward declarations.

  • Loading branch information
ksooo committed May 2, 2017
commit 29a63ec224c7eb8fbba280a448f0b2c676c78ef5
@@ -30,10 +30,8 @@ namespace PVR
{
class CPVRChannelGroup;
class CPVRChannelGroupInternal;
class CPVRChannelsContainer;
class CPVRChannel;
class CPVRChannelGroups;
class CPVRClient;

/** The PVR database */

@@ -33,9 +33,6 @@

namespace PVR
{
class CPVRTimerInfoTag;
class CPVRRecording;

class CPVRGUIInfo : private CThread,
private Observer
{
@@ -43,20 +43,13 @@
class CGUIDialogExtendedProgressBar;
class CGUIDialogProgressBarHandle;
class CStopWatch;
class CAction;
class CFileItemList;
class CVariant;

namespace PVR
{
class CPVRClient;
class CPVRClients;
class CPVRChannelGroupsContainer;
class CPVRChannelGroup;
class CPVRRecordings;
class CPVRTimers;
class CPVRGUIInfo;
class CPVRDatabase;

enum ContinueLastChannelOnStartup
{
@@ -34,7 +34,6 @@
namespace PVR
{
class CPVREpg;
class CPVRGUIInfo;

typedef std::shared_ptr<CPVRClient> PVR_CLIENT;
typedef std::map< int, PVR_CLIENT > PVR_CLIENTMAP;
@@ -36,7 +36,6 @@ class CFileItemList;

namespace PVR
{
class CPVRDatabase;
class CPVRChannelGroupInternal;

typedef struct
@@ -19,6 +19,7 @@
*
*/

#include "XBDateTime.h"
#include "settings/lib/ISettingCallback.h"

#include "pvr/PVRTypes.h"
@@ -28,7 +29,6 @@
#include <utility>
#include <vector>

class CDateTime;
class CFileItem;
typedef std::shared_ptr<CFileItem> CFileItemPtr;

@@ -38,10 +38,6 @@ namespace PVR
#define PVR_GROUP_TYPE_INTERNAL 1
#define PVR_GROUP_TYPE_USER_DEFINED 2

class CPVRChannelGroups;
class CPVRChannelGroupInternal;
class CPVRChannelGroupsContainer;

typedef struct
{
CPVRChannelPtr channel;
@@ -31,7 +31,6 @@
#include <vector>
#include <string>

class CFileItem;
class CSetting;

namespace PVR
@@ -29,10 +29,6 @@
* a EPG entry by giving the EPG information tag or as instant timer
* on currently tuned channel, or give a blank tag to modify later.
*
* With exception of the blank one, the tag can easily and unmodified added
* by the PVRManager function "bool AddTimer(const CFileItem &item)" to
* the backend server.
*
* The filename inside the tag is for reference only and gives the index
* number of the tag reported by the PVR backend and can not be played!
*/
@@ -44,14 +40,10 @@
#include "utils/ISerializable.h"
#include "XBDateTime.h"

class CFileItem;
class CVariant;

namespace PVR
{
class CGUIDialogPVRTimerSettings;
class CPVRChannelGroupInternal;

class CPVRTimerInfoTag : public ISerializable
{
public:
@@ -25,6 +25,7 @@

#include "addons/kodi-addon-dev-kit/include/kodi/xbmc_pvr_types.h"
#include "pvr/PVRSettings.h"
#include "pvr/PVRTypes.h"
#include "PVRTimerInfoTag.h"
#include "utils/Observer.h"
#include "XBDateTime.h"
@@ -35,7 +36,6 @@ typedef std::shared_ptr<CFileItem> CFileItemPtr;

namespace PVR
{
class CPVREpgInfoTag;
class CPVRRecording;
class CPVRTimersPath;

@@ -26,8 +26,6 @@
#include "pvr/PVRChannelNumberInputHandler.h"
#include "GUIWindowPVRBase.h"

class CSetting;

namespace PVR
{
class CGUIEPGGridContainer;
ProTip! Use n and p to navigate between commits in a pull request.
You can’t perform that action at this time.