Navigation Menu

Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[fix] amlogic: 4k resolutions after f9d8ab7 #12098

Merged
merged 1 commit into from May 16, 2017
Merged

Conversation

stefansaraev
Copy link
Contributor

@stefansaraev stefansaraev commented May 15, 2017

#11986 accidentally broke 4k resolutions on amlogic/linux, and I failed to test that ;)

Description

Motivation and Context

ERROR: failed to create EGL window surface 12291

^ then screen is split into 2 (or 4) depending if video is playing or not, and an old frame of kodi GUI is drawn stretched

I dont understand most of the egl code, but it seems to me that GUI is not supposed to run at 4k

ref https://github.com/xbmc/xbmc/blob/master/xbmc/utils/AMLUtils.cpp#L497-L498 and below.

How Has This Been Tested?

runtime tested on wetek play 2.

Screenshots (if appropriate):

Types of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the Code guidelines of this project
  • My change requires a change to the documentation, either Doxygen or wiki
  • I have updated the documentation accordingly
  • I have read the CONTRIBUTING document
  • I have added tests to cover my change
  • All new and existing tests passed

fyi @lrusak

cc @wrxtasy @kszaq can you reproduce and confirm this fixes the bug for you ?

@lrusak
Copy link
Contributor

lrusak commented May 15, 2017

Thanks!!!

@MartijnKaijser
Copy link
Member

Jenkins build this please
Ping @peak3d just in case

@stefansaraev
Copy link
Contributor Author

jenkins does not build this code path :)

@peak3d
Copy link
Contributor

peak3d commented May 16, 2017

from my side Ok if it works, I remember that this place was already a few times under change in the last decade. I guess / hope that you have tested it good....

@lrusak lrusak merged commit 95a82b7 into xbmc:master May 16, 2017
@stefansaraev stefansaraev deleted the aml-res branch May 16, 2017 15:58
@MartijnKaijser MartijnKaijser modified the milestone: L 18.0-alpha1 May 28, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants