Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Already on GitHub? Sign in to your account

Add method for allowing python to start and stop our servers... #1212

Merged
merged 2 commits into from Aug 1, 2012

Conversation

Projects
None yet
2 participants
Owner

Memphiz commented Jul 24, 2012

... well basically what the topic says. This is a feature request of at-visions.

Sry - fatfingered the first PR description g

Member

jmarshallnz commented Jul 24, 2012

Need to decide if you want to modify the gui settings or not with these methods. If you do, then shouldn't you be saving afterwards? If you don't, then modifying them to begin with is something that is not required - or do the StartWebServer et. al. check these?

Owner

Memphiz commented Jul 24, 2012

They check the guisetting... mhhh but as of the feature request i would say we should save it yes.

Owner

Memphiz commented Jul 24, 2012

does this look right (last commit)?

Member

jmarshallnz commented Jul 24, 2012

Changes look fine.

Owner

Memphiz commented Jul 24, 2012

squashed - will assign to august milestone for now.

@ghost ghost assigned Memphiz Jul 24, 2012

Memphiz added some commits Jul 24, 2012

[add] - add wrapper method for starting/stopping servers (jsonrpc, ze…
…roconf, upnprenderer, upnpserver, airplay, eventserver, webserver)

Memphiz added a commit that referenced this pull request Aug 1, 2012

Merge pull request #1212 from Memphiz/pythonserverctrl
Add method for allowing python to start and stop our servers...

@Memphiz Memphiz merged commit decdfb9 into xbmc:master Aug 1, 2012

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment