Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Already on GitHub? Sign in to your account

[fix] Make Gamepad Button Combo dialog work with AppleTV - fixes #12733 #1217

Closed
wants to merge 2 commits into
from

Conversation

Projects
None yet
3 participants
Contributor

killdash9 commented Jul 25, 2012

The Apple TV remote does not work in the Gamepad Dialog. I've added support for the up/down/left/right/OK buttons on the apple remote to work with the Gamepad Dialog.

http://trac.xbmc.org/ticket/12733

[fix] Make Gamepad Button Combo dialog work with AppleTV - fixes #12733
The Apple TV remote does not work in the Gamepad Dialog. I've added support for the up/down/left/right/OK buttons on the apple remote to work with the Gamepad Dialog.

http://trac.xbmc.org/ticket/12733

Thx - next time you don't need to do a new pull request - you can change your old branch and force push to your repo - this would automatically update the pull request then with your changes. Will attach this PR to the august merge window.

Member

jmarshallnz commented Jul 25, 2012

IMO we should just remove this dialog instead of implementing it for other devices.

Further, the code changes done don't apply only to the apple remote - they apply to any input device (so the comments are not correct).

Contributor

killdash9 commented Jul 25, 2012

The gamepad dialog is nicer than the number dialog in one sense because it allows a code to be entered much more efficiently and an observer watching the screen can determine the password with the number dialog, but not with the gamepad dialog.

Owner

Memphiz commented Jul 25, 2012

yep tested it ... now you also can use the gamepad combo with cursor keys and even with nyxboard (basically everything which uses these actions).

@jmarshallnz i though understand the reason for having a somewhat "cloaked" ability to enter a lock code...

@ghost

ghost commented Aug 8, 2012

the amount of lines we (possibly) git rm does not matter. this looks fine, and is confirmed working. nuke the comments and we can merge for now and settle the fate of the dialog later by throwing bikesheds at each other (dibs on the orange with a -1 tint) or whatever ;)

Contributor

killdash9 commented Aug 11, 2012

I have removed Apple TV-specific comments.

@ghost ghost assigned jmarshallnz Aug 12, 2012

Member

jmarshallnz commented Aug 12, 2012

Thanks - will pull in with some minor changes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment