Implements trac ticket #10796 - splits out view state by skin #122

1 commit merged into from Apr 30, 2011


None yet
1 participant

AaronDnz commented Apr 30, 2011

This was all done by spiff, I just got it working on the current master and tested that it works.

In the database code, it was trying to update any current entries in ViewModes to add the skin name to these. However, the current skin is not accessible from that code anymore (g_guiSettings) and I couldn't change the signature to add the skin name.

However, the code now tries to look up the view mode for the current skin, and if it can't find it then falls back to the first entry it can find for the same window and path. Hence, this effectively gives the same result without updating the existing table entries.


ghost commented Apr 30, 2011


@ghost ghost added a commit that referenced this pull request Apr 30, 2011

Arne Morten Kvarving Merge pull request #122 from AaronDnz/master.
Implements trac ticket #10796 - splits out view state by skin

@ghost ghost merged commit 19911bc into xbmc:master Apr 30, 2011

@garbear garbear pushed a commit to garbear/xbmc that referenced this pull request Mar 27, 2017

@peak3d peak3d Merge pull request #122 from peak3d/curlheader
CURLFile: Remove filter for unknown HTTP header / control log visibility of header values

This issue was closed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment