Cleanup resume #1220

Merged
merged 8 commits into from Aug 3, 2012
Commits on Aug 3, 2012
  1. [bookmarks] adds IsSet() and IsPartWay() to CBookmark

    Jonathan Marshall committed Jul 8, 2012
  2. [resume] use CBookmark::IsSet and CBookmark::IsPartWay for various sp…

    Jonathan Marshall committed Jul 8, 2012
    …ots we check for whether we've set or partly played an item.
    
    Two places need thought:
    1. VideoInfoScanner - currently we test IsPartWay() before setting the bookmark (if the user is importing bookmarks).
       Using IsSet() may be more appropriate if this routine can be used to override whatever is in the database already.
    
    2. ThumbLoader.cpp - this used to also check m_resumePoint.type == CBookmark::RESUME. However, nothing sets this to anything
       other than resume.
  3. use IsSet() instead of IsPartWay() when scanning in videos (to allow …

    Jonathan Marshall committed Aug 3, 2012
    …overriding of existing resume points with none) and when receiving the resume item offset (to allow plugins to override existing resume points with none)
  4. [resume] cleanup GetResumeString to reuse GetResumeItemOffset

    Jonathan Marshall committed Jul 8, 2012
  5. [resume] if a played item has a resume point set in its videoinfotag,…

    Jonathan Marshall committed Jul 8, 2012
    … use it over and above the database value when resuming in the player
  6. [resume] Add properties to allow "resumepoint" and "totaltime" to be …

    hippojay committed with Jonathan Marshall Jul 9, 2012
    …set via setProperty from python. These tags override any resume information in the video database.
  7. [resume] CVideoDatabase::GetPlayCounts no longer overrides informatio…

    hippojay committed with Jonathan Marshall Jul 9, 2012
    …n set in the items, which we assume may be more up to date.
  8. [resume] if plugins set the resumetime in setResolvedURL(), then assu…

    hippojay committed with Jonathan Marshall Jul 9, 2012
    …me they want the item to resume.