Join GitHub today
GitHub is home to over 31 million developers working together to host and review code, manage projects, and build software together.Sign up
[Python] Fix xbmcgui.Window methods to get the actual size of a Window #12279
This PR fixes
Motivation and Context
xbmcgui Controls are placed using pixel coordinates from the top left corner. However, currently there is no way to determine the the actual pixel size of the visible area (pixel coordinate grid) of a Window instance. Existing
How Has This Been Tested?
I compiled the code in Vusial Studio 2015 on Windows 10. Then I built a Windows installer and installed Kodi from it. After that I ran a simple testing addon and checked if those fixed methods and new functions actually work using an interactive Python debugger.
Screenshots (if appropriate):
Types of change
A window should normally return it's actually width and height not the display resolution. If that's the case we should change the implementation of
I agree with you but since this my very first PR to the Kodi core code, I didn't feel right to change the existing code. But yes, logically, a