Video calibrations loading broke after the GUI creation was moved.
This is a bit more flexible than it was because it allows to apply calibrations for resolutions being added while is running. Typical use case when a user connects a projector.
+1 for asap merge :)
If the typo is fixed i can confirm that xbmc loads my handcrafted calibration. Good work on that one. If FernetMenta gets to fix the compilation (because of the iHight typo) we should consider merging this fix before the alpha5 tag aswell...
video calibration fix, broke after 9ad6f4e
Well to late - versions already bumped. Assign it to august merge window and merge if you ask me (it will hit nightlies and alpha5 then). Please also track this PR in the August merge thread in the forum.
Fix - merge at will.
Warning : I had a strange issue when tested it. Video played fine on my standard PC with a VGA PC screen, but was totaly broken on my PC to view video, linked by HDMI to my audio receveir, and TV screen afterward. Video was ultra zommed, i think roughly only the upper left quarter was displayed. I'll have to make more test (but compliling is long), to check if it this patch, or if actual git is broken.
Make sure your receiver is powered up before you start XBMC.
It is, that's for sure, as all HDMI enter in receiver, and after output to TV => Receiver off => No screen...
Receiver if powered on even before i power on the PC.
What is the status? Are you sure this commit breaks your system?
I have to compile two version, one updated to last git i'll do very shortly, and the same with the patch, but compile take around half an hour for me, so, expect me to be back with result no before at least an hour... More likely in two hours.
As i said, it'll take time for me to check.
Honestly - imo its more then unlikly that this patch leads to the reported problem. Just look at the code. Its doesn't care where you plug in your tv. If the calibrations are not matching for receiver and vga, then its not XBMCs fault imho.
Did you turn on your xbmc box while the display was shut off? This for me leads to a problem almost exactly as you've described here.
It's not the patch, something broke video display in git update between the 28/07 and yesterday.
Check ticket 13224, the problem is in master. Software rendering on Windows is broken,
Any idea if this PR could lead to growing guisettings.xml on profile changes? (resolutions get written over and over again and make the file huge like gozilla) Described here:
Couldn't reproduce it.
A resolution is defined by a string like this "720x480 @ 29.97 - Full Screen". I would assume that this string changes when they switch profiles. Unfortunately all links in the post are expired.
The vector m_calibrations is not cleared in LoadCalibrations(). This can lead to duplicate entries if settings are loaded more than once. I am not aware that this can happen.
Nevertheless, it is a good practice to do so. Will provide a fix tomorrow with a check for duplicate entries. This way users get rid of duplicates without having to manually edit guisettings.
Fix Consider adjusting context menu item if PQ of that item type does…
…n't exist #1231