Skip to content

video calibration fix #1231

Merged
merged 1 commit into from Aug 5, 2012

6 participants

@FernetMenta
Team Kodi member

Video calibrations loading broke after the GUI creation was moved.

This is a bit more flexible than it was because it allows to apply calibrations for resolutions being added while is running. Typical use case when a user connects a projector.

@mkortstiege
Team Kodi member

+1 for asap merge :)

@FernetMenta
Team Kodi member

Updated

@Memphiz
Team Kodi member
Memphiz commented Jul 31, 2012

If the typo is fixed i can confirm that xbmc loads my handcrafted calibration. Good work on that one. If FernetMenta gets to fix the compilation (because of the iHight typo) we should consider merging this fix before the alpha5 tag aswell...

@Memphiz
Team Kodi member
Memphiz commented Aug 1, 2012

Well to late - versions already bumped. Assign it to august merge window and merge if you ask me (it will hit nightlies and alpha5 then). Please also track this PR in the August merge thread in the forum.

@FernetMenta FernetMenta was assigned Aug 4, 2012
@jmarshallnz
Team Kodi member

Fix - merge at will.

@jpsdr
jpsdr commented Aug 5, 2012

Warning : I had a strange issue when tested it. Video played fine on my standard PC with a VGA PC screen, but was totaly broken on my PC to view video, linked by HDMI to my audio receveir, and TV screen afterward. Video was ultra zommed, i think roughly only the upper left quarter was displayed. I'll have to make more test (but compliling is long), to check if it this patch, or if actual git is broken.

@FernetMenta
Team Kodi member

@jpsdr
Make sure your receiver is powered up before you start XBMC.

@jpsdr
jpsdr commented Aug 5, 2012

It is, that's for sure, as all HDMI enter in receiver, and after output to TV => Receiver off => No screen...
Receiver if powered on even before i power on the PC.

@FernetMenta
Team Kodi member

@jpsdr
What is the status? Are you sure this commit breaks your system?

@jpsdr
jpsdr commented Aug 5, 2012

I have to compile two version, one updated to last git i'll do very shortly, and the same with the patch, but compile take around half an hour for me, so, expect me to be back with result no before at least an hour... More likely in two hours.
As i said, it'll take time for me to check.

@Memphiz
Team Kodi member
Memphiz commented Aug 5, 2012

Honestly - imo its more then unlikly that this patch leads to the reported problem. Just look at the code. Its doesn't care where you plug in your tv. If the calibrations are not matching for receiver and vga, then its not XBMCs fault imho.

@Begall
Begall commented Aug 5, 2012

Did you turn on your xbmc box while the display was shut off? This for me leads to a problem almost exactly as you've described here.

@jpsdr
jpsdr commented Aug 5, 2012

It's not the patch, something broke video display in git update between the 28/07 and yesterday.

@FernetMenta
Team Kodi member

@Memphiz
Check ticket 13224, the problem is in master. Software rendering on Windows is broken,

@FernetMenta FernetMenta merged commit dea8c9b into xbmc:master Aug 5, 2012
@Memphiz
Team Kodi member
Memphiz commented Sep 26, 2012

@FernetMenta

Any idea if this PR could lead to growing guisettings.xml on profile changes? (resolutions get written over and over again and make the file huge like gozilla) Described here:

http://forum.xbmc.org/showthread.php?tid=138804&page=2

Couldn't reproduce it.

@FernetMenta
Team Kodi member

A resolution is defined by a string like this "720x480 @ 29.97 - Full Screen". I would assume that this string changes when they switch profiles. Unfortunately all links in the post are expired.

@FernetMenta
Team Kodi member

The vector m_calibrations is not cleared in LoadCalibrations(). This can lead to duplicate entries if settings are loaded more than once. I am not aware that this can happen.
Nevertheless, it is a good practice to do so. Will provide a fix tomorrow with a check for duplicate entries. This way users get rid of duplicates without having to manually edit guisettings.

@LongChair LongChair added a commit to plexinc/plex-home-theater-public that referenced this pull request Aug 1, 2014
@LongChair LongChair Fix Consider adjusting context menu item if PQ of that item type does…
…n't exist #1231
825d59a
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Something went wrong with that request. Please try again.