New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[fix] coverity issues #12375
Merged
Merged
[fix] coverity issues #12375
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Rechi
added
Type: Fix
non-breaking change which fixes an issue
Type: Improvement
non-breaking change which improves existing functionality
v18 Leia
labels
Jun 27, 2017
jenkins build this please |
@Montellese are the web server changes okay? |
@Rechi: webserver changes look ok. I'm actually confused because I did those changes during my last webserver cleanup as well but I had to do quite a few rebases there so maybe I lost that commit (and hopefully only that one). |
Montellese
approved these changes
Jun 28, 2017
AlwinEsch
approved these changes
Jun 28, 2017
any objections? |
The parameters aren't used anywhere. fixes CID 169946, 169949, 169950, 169962, 169964, 169965, 169968 and 169973
Pass parameters by reference instead passing them by value fixes CID 169940, 169941, 169942, 169945, 169948, 169953, 169955, 169956, 169957, 169966, 169967, 169969
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Type: Fix
non-breaking change which fixes an issue
Type: Improvement
non-breaking change which improves existing functionality
v18 Leia
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fix a few coverity issues
Motivation and Context
reduce coverity issues
How Has This Been Tested?
build for windows and osx
Types of change
Checklist: