Navigation Menu

Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[fix] coverity issues #12375

Merged
merged 9 commits into from Jun 30, 2017
Merged

[fix] coverity issues #12375

merged 9 commits into from Jun 30, 2017

Conversation

Rechi
Copy link
Member

@Rechi Rechi commented Jun 27, 2017

Description

Fix a few coverity issues

Motivation and Context

reduce coverity issues

How Has This Been Tested?

build for windows and osx

Types of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the Code guidelines of this project
  • My change requires a change to the documentation, either Doxygen or wiki
  • I have updated the documentation accordingly
  • I have read the CONTRIBUTING document
  • I have added tests to cover my change
  • All new and existing tests passed

@Rechi Rechi added Type: Fix non-breaking change which fixes an issue Type: Improvement non-breaking change which improves existing functionality v18 Leia labels Jun 27, 2017
@Rechi Rechi added this to the L 18.0-alpha1 milestone Jun 27, 2017
@Rechi
Copy link
Member Author

Rechi commented Jun 27, 2017

jenkins build this please

@Rechi
Copy link
Member Author

Rechi commented Jun 28, 2017

@Montellese are the web server changes okay?
don't know whom I should ping for the other changes

@Montellese
Copy link
Member

@Rechi: webserver changes look ok. I'm actually confused because I did those changes during my last webserver cleanup as well but I had to do quite a few rebases there so maybe I lost that commit (and hopefully only that one).

@AlwinEsch AlwinEsch self-requested a review June 28, 2017 21:00
@Rechi
Copy link
Member Author

Rechi commented Jun 29, 2017

any objections?

@Rechi Rechi merged commit 8832fc9 into xbmc:master Jun 30, 2017
@Rechi Rechi deleted the fixCoverity branch June 30, 2017 08:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: Fix non-breaking change which fixes an issue Type: Improvement non-breaking change which improves existing functionality v18 Leia
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants