Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[fix] coverity issues #12375

Merged
merged 9 commits into from Jun 30, 2017

Conversation

@Rechi
Copy link
Member

commented Jun 27, 2017

Description

Fix a few coverity issues

Motivation and Context

reduce coverity issues

How Has This Been Tested?

build for windows and osx

Types of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the Code guidelines of this project
  • My change requires a change to the documentation, either Doxygen or wiki
  • I have updated the documentation accordingly
  • I have read the CONTRIBUTING document
  • I have added tests to cover my change
  • All new and existing tests passed

@Rechi Rechi added this to the L 18.0-alpha1 milestone Jun 27, 2017

@Rechi Rechi force-pushed the Rechi:fixCoverity branch from ce18e4f to f2aa2a5 Jun 27, 2017

@Rechi

This comment has been minimized.

Copy link
Member Author

commented Jun 27, 2017

jenkins build this please

@Rechi

This comment has been minimized.

Copy link
Member Author

commented Jun 28, 2017

@Montellese are the web server changes okay?
don't know whom I should ping for the other changes

@Montellese

This comment has been minimized.

Copy link
Member

commented Jun 28, 2017

@Rechi: webserver changes look ok. I'm actually confused because I did those changes during my last webserver cleanup as well but I had to do quite a few rebases there so maybe I lost that commit (and hopefully only that one).

@AlwinEsch AlwinEsch self-requested a review Jun 28, 2017

@Rechi

This comment has been minimized.

Copy link
Member Author

commented Jun 29, 2017

any objections?

@Rechi Rechi force-pushed the Rechi:fixCoverity branch from 6eb7bb1 to 9e1ea88 Jun 30, 2017

@Rechi Rechi merged commit 8832fc9 into xbmc:master Jun 30, 2017

1 check passed

default You're awesome. Have a cookie
Details

@Rechi Rechi deleted the Rechi:fixCoverity branch Jun 30, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.