Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[win32] re-work WinSystemWin32 + RenderSystemDX #12377

Merged
merged 4 commits into from Jul 25, 2017

Conversation

@afedchin
Copy link
Member

commented Jun 27, 2017

In order to preparation for UWP I reworked Win32 windowing and rendering subsystems to make it possible to reuse dx code with minimal changes in uwp part.

@@ -273,8 +273,54 @@ template <typename T> class CRectGen
}
};

template <typename T> struct SizeGen

This comment has been minimized.

Copy link
@FernetMenta

FernetMenta Jun 28, 2017

Member

this entire block here is platform code, only used on Windows, right?

This comment has been minimized.

Copy link
@afedchin

afedchin Jun 28, 2017

Author Member

right, currently it's used on windows only

This comment has been minimized.

Copy link
@FernetMenta

FernetMenta Jun 28, 2017

Member

why don't you move it to some windows only file? I think this is much better than those kind of workarounds: 17a9442

@afedchin afedchin force-pushed the afedchin:windowing branch from e3e11d2 to 17a9442 Jun 28, 2017

@MartijnKaijser

This comment has been minimized.

Copy link
Member

commented Jun 29, 2017

jenkins build this please

@afedchin afedchin force-pushed the afedchin:windowing branch 2 times, most recently from d3bc472 to b0fa7c2 Jun 29, 2017

@afedchin afedchin force-pushed the afedchin:windowing branch 8 times, most recently from f4b4967 to 6f51ca9 Jul 3, 2017

@afedchin

This comment has been minimized.

Copy link
Member Author

commented Jul 7, 2017

jenkins build this please

@afedchin afedchin added the No Jenkins label Jul 7, 2017

@afedchin afedchin force-pushed the afedchin:windowing branch 2 times, most recently from f3b8800 to 3a0be26 Jul 7, 2017

@Rechi

This comment has been minimized.

Copy link
Member

commented Jul 11, 2017

@afedchin this needs a rebase

@afedchin afedchin force-pushed the afedchin:windowing branch 3 times, most recently from af5f8ca to 6cd8c78 Jul 17, 2017

@afedchin afedchin force-pushed the afedchin:windowing branch from 400d727 to 0c24492 Jul 23, 2017

@afedchin afedchin changed the title [WIP] [win32] re-work WinSystemWin32 + RenderSystemDX [win32] re-work WinSystemWin32 + RenderSystemDX Jul 23, 2017

@afedchin

This comment has been minimized.

Copy link
Member Author

commented Jul 23, 2017

jenkins build this please

@Rechi

This comment has been minimized.

Copy link
Member

commented Jul 25, 2017

@afedchin is this ready or does it still need some work?

jenkins build this please

wchar_t* keyName =
#ifndef _M_X64
// on x64 system and x32 build use UserModeDriverNameWow key
CSysInfo::GetKernelBitness() == 64 ? keyName = L"UserModeDriverNameWow" :

This comment has been minimized.

Copy link
@Rechi

Rechi Jul 25, 2017

Member

#include "utils/SystemInfo.h" is missing

This comment has been minimized.

Copy link
@afedchin

afedchin Jul 25, 2017

Author Member

thanks.

@afedchin afedchin force-pushed the afedchin:windowing branch from 0c24492 to f7138fb Jul 25, 2017

@Rechi

This comment has been minimized.

Copy link
Member

commented Jul 25, 2017

unrelated Android-ARM failure

@afedchin

This comment has been minimized.

Copy link
Member Author

commented Jul 25, 2017

ok then. If this introduce new bugs, we will fix them.

@afedchin afedchin merged commit 0d6b3ce into xbmc:master Jul 25, 2017

1 check failed

default Sorry, building this PR failed. Please check the logs for the errors.
Details

@afedchin afedchin deleted the afedchin:windowing branch Jul 25, 2017

@Rechi Rechi added this to the L 18.0-alpha1 milestone Jul 25, 2017

@akva2

This comment has been minimized.

Copy link
Contributor

commented on xbmc/rendering/dx/DeviceResources.h in 1913ce5 Jul 28, 2017

what is this funky thing?

This comment has been minimized.

Copy link
Member Author

replied Jul 28, 2017

what do you mean? this will be used on uwp platform. I know that there is missing closing parenthesis, and it will be fixed.

This comment has been minimized.

Copy link
Contributor

replied Jul 28, 2017

there is some funky unicode chars in use. this trips static analyzers and annoys my editors.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
5 participants
You can’t perform that action at this time.