Skip to content

Loading…

[UPnP] Code shuffle #1238

Merged
merged 7 commits into from

6 participants

@alcoheca

This is pretty basic stuff & should ideally go in at the same time as the Platinum upgrade.

Moves upnp files to xbmc/network/upnp, adds a UPNP namespace & makes UPnP actually optional at configure time (enabled by default).

Depends on upgrade-platinum pull request

@elupus
Team Kodi member
@elupus elupus commented on an outdated diff
lib/libUPnP/Makefile.in
((5 lines not shown))
Neptune/Source/System/Posix/NptPosixQueue.cpp \
Neptune/Source/System/Posix/NptPosixThreads.cpp \
Neptune/Source/System/Posix/NptPosixFile.cpp \
- Neptune/Source/System/StdC/NptStdCTime.cpp \
+ Neptune/Source/System/Posix/NptPosixTime.cpp \
@elupus Team Kodi member
elupus added a note

this is part of the upgrade not the shuffle right?

@elupus Team Kodi member
elupus added a note

nevermind.. the upgrade is in this pull too.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
@alcoheca

only c640c4b & 49348d1 are relevant, rest is from platinum-upgrade pull request

@elupus
Team Kodi member

Looking pretty good, but needs rebase and some squashes. We don't want to have commits where xbmc is not in a compiling state.

@alcoheca

@elupus i squashed the first two commits of upgrade-platinum. forced pushed, then rebased onto code-shuffle. Hopefully that's it sorted?

@alcoheca

I don't know why the ordering is weird here, it's correct in my git logs for both branches

@jmarshallnz
Team Kodi member
@alcoheca

hello hello, any chance of getting this in too?

needs platform fixes for 02f566d, 9f3e4a6 & 410cda4. hopefully the last time I touch configure.in ... think @pieh is willing to do win32 so it's just the 3 osx builds which need coaxed into submission

@Memphiz
Team Kodi member

Since xcode doesn't have conditional compilation of files i would think we have to enable it in the osx configure. @Davilla what do you think?

Or we would need to remove the whole libupnp from the osx project and let xcode_depends build it - then add some HAS_UPNP guards on the filesystem and network bits of UPNP so that those get not compiled.

@ghost

move it to depends imo. it is an external library.

@davilla

What patches are we carrying for upnp ?
Currently libUpnp is made as a static lib (libupnp.a) that we hard link.
Also, think of darwin builds as embedded, we choose what to enable/disable and we only support building under our depends build system. If someone is doing configure outside of tool/darwin/depends/xbmc/Makefile, that's their problem, not ours.
We could also move upnp into xcode_depends but I'd rather that get less usage than more.

@alcoheca
@alcoheca

if this is a massive pain in the arse, we could forgo making UPnP optional - I just felt it was a half way done job, seeing as there was IFDEF UPnP's all over the shop..

The most important change is splitting the classes out of UPnP.cpp - it's a nightmare to spend anytime in there right now.

@Memphiz
Team Kodi member

@davilla as extract of your post - enable it in tools/darwin/depends/xbmc/Makefile and leave it in the xcode project. I'm fine with that.

@alcoheca will shuffle the stuff in xcode and then do a PR to your branch (and hope nobody commits any project changes until you hit the green button).

@Memphiz
Team Kodi member

PR sent.

@pieh
Team Kodi member

and windows pr sent too alcoheca#4
as we have total merge mayhem now, no sense in playing games to keep stuff building in each commit

@alcoheca alcoheca merged commit c3cfbf1 into xbmc:master
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Commits on Sep 7, 2012
  1. @alcoheca
  2. @alcoheca

    [UPnP] changed: make UPnP optional (enabled by default), fix some mis…

    alcoheca committed
    …sing #ifdef HAS_UPNP guards
  3. @alcoheca

    [UPnP] split off UPnPServer to separate file. move some static class …

    alcoheca committed
    …methods to
    
    helpers via internal header
  4. @alcoheca
  5. @Memphiz @alcoheca

    [darwin/deps] - configure with --enable-upnp explicitly because xcode…

    Memphiz committed with alcoheca
    … project needs this to be on (who knows if the default will switch over to disabled sometime haha)
  6. @Memphiz @alcoheca
  7. @pieh @alcoheca
Something went wrong with that request. Please try again.