[GUI] Allow recursive usage of idCollector in CGUIControlGroup #12520
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
peak3d
changed the title
peak3d
added
Type: Fix
peak3d
changed the title
|
Jenkins build this please |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[GUI] Allow recursice usage of idlookup in CGUIControlGroup
Description
CGUIControl::SendControlmessage is can be called recursice (e.g. closing a video with "x")
This leads to reusage of m_idLookup (wich was introduced for performance reasons) member.
Motivation and Context
Kodi on Win64 segfaults if pressing x during a running video
How Has This Been Tested?
Win10 / x64 / 7TV addon / starting a stream / press x
Types of change