Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Game OSD: New dialog for video settings #12639

Merged
merged 13 commits into from Aug 25, 2017
Merged

Game OSD: New dialog for video settings #12639

merged 13 commits into from Aug 25, 2017

Conversation

@garbear
Copy link
Member

garbear commented Aug 5, 2017

This adds a new dialog for selecting video effects in realtime.

Description

For reference, here is the old Game OSD:

screenshot004

I added nice icons, and moved the settings to a new dialog based on Custom_1101_SettingsList.xml used in the Video OSD.

screenshot000

screenshot001

Both "Video filters" and "View mode" use the same XML, GameOSDVideoSelect.xml. As the user scrolls, the game in the background is updated to use the focused scaling mode/view mode.

screenshot002

Currently, "Video filters" show a list of scaling modes. In the future, these will be replaced with shader effects.

View mode allows the user to select how the game is stretched to fill the display.

screenshot003

As part of the GSoC shader project, RetroPlayer is getting a new renderer that will allow previews to be drawn. For now, we just show a static image.

Motivation and Context

We need a live fullscreen preview to show off our awesome shader work for GSoC.

How Has This Been Tested?

Test builds are available in my test builds thread: https://forum.kodi.tv/showthread.php?tid=173361

Types of change

  • Bug fix (non-breaking change which fixes an issue)
  • Improvement (non-breaking change which improves existing functionality)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
@garbear garbear added this to the L 18.0-alpha1 milestone Aug 5, 2017
@garbear

This comment has been minimized.

Copy link
Member Author

garbear commented Aug 6, 2017

I've uploaded some test builds to my test builds thread: https://forum.kodi.tv/showthread.php?tid=173361

@garbear garbear force-pushed the garbear:video-settings branch 2 times, most recently from 63dc0b2 to 693c812 Aug 8, 2017
@garbear

This comment has been minimized.

Copy link
Member Author

garbear commented Aug 8, 2017

pushed a commit that removes the dialogs' dependence on IPlayer, instead RetroPlayer registers itself with the dialogs

@garbear

This comment has been minimized.

Copy link
Member Author

garbear commented Aug 11, 2017

I've pushed a new update. This adds a gamewindow control, similar to videowindow, and allows the rendering properties to be set. Now, the thumbnails in the dialog are rendered according to their effect.

screen shot 2017-08-11 at 1 58 52 pm

@garbear

This comment has been minimized.

Copy link
Member Author

garbear commented Aug 12, 2017

Thanks to feedback from Rantanplan-1, I was able to combine GameOSDVideoSelect into DialogSelect in the latest commit.

@DaveTBlake

This comment has been minimized.

Copy link
Member

DaveTBlake commented Aug 13, 2017

Forgive me if this is OT, but I just noticed that are in guisettings.xml in the old tag format, not the new false format. This is true for some other settings too, not just game. Should there be some update to the settings save/load implementation?

@garbear

This comment has been minimized.

Copy link
Member Author

garbear commented Aug 14, 2017

Are you saying that the MediaSettings, including VideoSettings and the new GameSettings, are saved using the old format? If so, these should eventually be transitioned to the new format. Out of scope of this PR though, right?

@DaveTBlake

This comment has been minimized.

Copy link
Member

DaveTBlake commented Aug 15, 2017

I'm sure out of scope :)
I just happened to be looking at MediaSettings, and using the game settings for hints on how to do things, then had doubts. Hence raising it to make you aware and/or find out what the plan is (if there is one).

@garbear

This comment has been minimized.

Copy link
Member Author

garbear commented Aug 15, 2017

If MediaSettings are saved using the old format, then a patch moving them to the new one would be welcome.

jenkins build this please

@garbear

This comment has been minimized.

Copy link
Member Author

garbear commented Aug 24, 2017

Added a manager for game control rendering settings. jenkins build this please

@garbear

This comment has been minimized.

Copy link
Member Author

garbear commented Aug 25, 2017

jenkins build this please

@garbear garbear force-pushed the garbear:video-settings branch from 869506d to ecd0061 Aug 25, 2017
@garbear

This comment has been minimized.

Copy link
Member Author

garbear commented Aug 25, 2017

unrelated errors on linux 64, rpi and ios

jenkins build this please

@garbear garbear force-pushed the garbear:video-settings branch from ecd0061 to ad8c5b4 Aug 25, 2017
@garbear

This comment has been minimized.

Copy link
Member Author

garbear commented Aug 25, 2017

Linux 64, rpi and ios 64 succeeded

@garbear garbear merged commit e35491d into xbmc:master Aug 25, 2017
1 check was pending
1 check was pending
default Found some time, building it now.
Details
@garbear garbear deleted the garbear:video-settings branch Aug 25, 2017
@gade01

This comment has been minimized.

Copy link

gade01 commented Aug 26, 2017

@garbear Isn't GameOSDVideoSelect.xml merged into DialogSelect.xml and should be removed?

@garbear

This comment has been minimized.

Copy link
Member Author

garbear commented Aug 26, 2017

Looks like it got accidentally re-added after being removed. #12720

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.