New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[pvr] PVR Addon API 5.7.1: Support for passing MimeType for PVR streams #12755
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Next time, please don't forget to label the PR "PVR Addon API change". And I always explain in detail in the description of such PRs what the changes mean exactly for the PVR Addon maintainers (assuming they read PRs flagged "PVR API change") - for instance, whether addon code must be adjusted and how or whether a recompile of the addon is sufficient.
xbmc/addons/PVRClient.cpp
Outdated
fileItem.SetContentLookup(false); | ||
} | ||
else | ||
fileItem.SetProperty(properties[i].strName, properties[i].strValue); |
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
@@ -114,7 +114,7 @@ | |||
#define ADDON_INSTANCE_VERSION_PERIPHERAL_DEPENDS "addon-instance/Peripheral.h" \ | |||
"addon-instance/PeripheralUtils.h" | |||
|
|||
#define ADDON_INSTANCE_VERSION_PVR "5.7.0" | |||
#define ADDON_INSTANCE_VERSION_PVR "5.7.1" |
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
Description
Allow setting Mime-Type for PVR streams + Disable Content-Lokup for known streams.
Todos for addon maintainers: none, as minimum pvr api version number did not change.
Motivation and Context
Mime-Type content lookup takes some time (HEAD Request) and can be supressed if PVR addon knows the mime type. Speeds up channel switching.
Should not lead to version issues because PVR_VERSION_MIN is unchanged.
How Has This Been Tested?
pvr.zattoo + mpeg DASH streams
Types of change