Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[pvr] PVR Addon API 5.7.1: Support for passing MimeType for PVR streams #12755

Merged
merged 1 commit into from Sep 5, 2017
Merged

[pvr] PVR Addon API 5.7.1: Support for passing MimeType for PVR streams #12755

merged 1 commit into from Sep 5, 2017

Conversation

peak3d
Copy link
Contributor

@peak3d peak3d commented Sep 1, 2017

Description

Allow setting Mime-Type for PVR streams + Disable Content-Lokup for known streams.

Todos for addon maintainers: none, as minimum pvr api version number did not change.

Motivation and Context

Mime-Type content lookup takes some time (HEAD Request) and can be supressed if PVR addon knows the mime type. Speeds up channel switching.

Should not lead to version issues because PVR_VERSION_MIN is unchanged.

How Has This Been Tested?

pvr.zattoo + mpeg DASH streams

Types of change

  • Bug fix (non-breaking change which fixes an issue)
  • Improvement (non-breaking change which improves existing functionality)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Copy link
Member

@ksooo ksooo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Next time, please don't forget to label the PR "PVR Addon API change". And I always explain in detail in the description of such PRs what the changes mean exactly for the PVR Addon maintainers (assuming they read PRs flagged "PVR API change") - for instance, whether addon code must be adjusted and how or whether a recompile of the addon is sufficient.

fileItem.SetContentLookup(false);
}
else
fileItem.SetProperty(properties[i].strName, properties[i].strValue);

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

@@ -114,7 +114,7 @@
#define ADDON_INSTANCE_VERSION_PERIPHERAL_DEPENDS "addon-instance/Peripheral.h" \
"addon-instance/PeripheralUtils.h"

#define ADDON_INSTANCE_VERSION_PVR "5.7.0"
#define ADDON_INSTANCE_VERSION_PVR "5.7.1"

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

@ksooo ksooo added this to the L 18.0-alpha1 milestone Sep 1, 2017
@ksooo ksooo changed the title Support for passing MimeType for PVR streams [pvr] PVR Addon API 5.7.1: Support for passing MimeType for PVR streams Sep 1, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants