New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

VideoPlayer: make OpenFile asynchron #12797

Merged
merged 2 commits into from Sep 14, 2017

Conversation

@FernetMenta
Member

FernetMenta commented Sep 13, 2017

Instead of blocking in OpenFile VideoPlayer always returns true and fires OnPlaybackError in case of error.

Create();
if (!CGUIDialogBusy::WaitOnEvent(m_openEvent, g_advancedSettings.m_videoBusyDialogDelay_ms, true))

This comment has been minimized.

@ksooo

ksooo Sep 13, 2017

Member

Please remove m_videoBusyDialogDelay_ms from CAdvancedSettings as it is now unused.

@ksooo

ksooo Sep 13, 2017

Member

Please remove m_videoBusyDialogDelay_ms from CAdvancedSettings as it is now unused.

This comment has been minimized.

@ksooo

ksooo Sep 13, 2017

Member

Please remove #include "dialogs/GUIDialogBusy.h" from this source file as you are no longer using CGUIDialogBusy here.

@ksooo

ksooo Sep 13, 2017

Member

Please remove #include "dialogs/GUIDialogBusy.h" from this source file as you are no longer using CGUIDialogBusy here.

Show outdated Hide outdated xbmc/cores/VideoPlayer/VideoPlayer.cpp
@FernetMenta

This comment has been minimized.

Show comment
Hide comment
@FernetMenta

FernetMenta Sep 13, 2017

Member

updated
great that we could even kill another advanced setting. thanks for review

Member

FernetMenta commented Sep 13, 2017

updated
great that we could even kill another advanced setting. thanks for review

@ksooo

This comment has been minimized.

Show comment
Hide comment
@ksooo

ksooo Sep 13, 2017

Member

@MilhouseVH could you please include this PR in your next build, so that we can get feedback from the affected users?

Member

ksooo commented Sep 13, 2017

@MilhouseVH could you please include this PR in your next build, so that we can get feedback from the affected users?

@MilhouseVH

This comment has been minimized.

Show comment
Hide comment
@MilhouseVH

MilhouseVH Sep 13, 2017

Contributor

OK

Contributor

MilhouseVH commented Sep 13, 2017

OK

@ksooo

This comment has been minimized.

Show comment
Hide comment
@ksooo

ksooo Sep 14, 2017

Member

We got very positive feedback from the testers.

Member

ksooo commented Sep 14, 2017

We got very positive feedback from the testers.

@ksooo

ksooo approved these changes Sep 14, 2017

@ksooo ksooo merged commit cc34be7 into xbmc:master Sep 14, 2017

1 check passed

default You're awesome. Have a cookie
Details

@Rechi Rechi added this to the L 18.0-alpha1 milestone Sep 14, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment