Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RaspberryPI support #1282

Merged
merged 62 commits into from Sep 4, 2012

Conversation

@huceke
Copy link
Contributor

commented Aug 12, 2012

This PR brings RaspberryPI support to XBMC. :

1.) Library wrapper for the host and omx implementation.

2.) EGL windowing support.

The EGL windowing needed some enhancments to get the full fange of display modes. Android needs testing if the changes do not break it.

3.) Additional pseudo 3D display modes for the PI.

We are able to use 3D modes on the PI. XBMC does not render the GUI double, this done by the firmware. For this there are new 3D modes.

4.) OMXPlayer.

OMXPlayer is an aditional player for the PI, close based on DVDPlayer. The player does not use AE out of the OMX nature. It is also able to use hardware audio decoding when the user has the licence for it.

5.) Changes to the player selection.

The default player selection in xbmc is too cosy with DVDPlayer.

6.) Build infrastructure simmiliar to android.

The forgotten points are in the source ..... ;)

huceke added 29 commits Aug 10, 2012
[rbp] cec: added support for the Raspberry Pi. needs libCEC v1.8.0+. …
…other targets are still supported by libCEC 1.7.0
[rbp] fixed crash in thumbnail extraction. disable all ffmpeg cpu opt…
…ions for now, until we figgured out which ones are safe to use on the PI arm core
@huceke

This comment has been minimized.

Copy link
Contributor Author

commented Aug 13, 2012

@opdenkamp : Do so. Thx

@Pezmc

This comment has been minimized.

Copy link

commented Sep 2, 2012

@peol Can't this be split into some of the major problems as separate pull requests. E.g. the force HDMI and Downmixing AC3

@ghost ghost assigned huceke Sep 4, 2012

huceke added a commit that referenced this pull request Sep 4, 2012

@huceke huceke merged commit 45fe6fc into xbmc:master Sep 4, 2012

@ace20022

This comment has been minimized.

Copy link
Member

commented on 19793b2 Sep 5, 2012

@opdenkamp Hi Lars, I'm afraid that you forgot to upload the file to the server. If this is automated and just takes some time, I apologize.

This comment has been minimized.

Copy link
Member Author

replied Sep 5, 2012

yeah indeed, there's a comment about this on the original commit/pr. i've asked in the internal irc channel whether someone can upload it.

@Voyager1

This comment has been minimized.

Copy link
Member

commented Sep 5, 2012

all - there's an issue with this - all video now plays at half-height (platform = Windows). Reverting this PR solves it for me.

@Memphiz

This comment has been minimized.

Copy link
Member

commented Sep 5, 2012

I saw something similar on linux.

moved .xbmc away - restart - still an issue - moved .xbmc back - restart - all fine. Not sure what was wonky there.

@FernetMenta

This comment has been minimized.

Copy link
Member

commented Sep 5, 2012

Did some investigation. Changes in BaseRenderer seem to be wrong. I always get a wrong refresh rate chosen.

@Memphiz

This comment has been minimized.

Copy link
Member

commented Sep 5, 2012

same it doesn't switch at all (stays at 60 hz). And now i got the state again where the movie height is wrong...

@Memphiz

This comment has been minimized.

Copy link
Member

commented Sep 5, 2012

see this screeny https://dl.dropbox.com/u/30371861/wrongheight.png

somehow the size info is missing in the osd too isn't it?

@Memphiz

This comment has been minimized.

Copy link
Member

commented Sep 5, 2012

i only get this on linux as it seems...

@Voyager1

This comment has been minimized.

Copy link
Member

commented Sep 5, 2012

I had it on Windows (Release) but not in the debug build... beats me :-)

@Memphiz

This comment has been minimized.

Copy link
Member

commented Sep 5, 2012

correction - the wrong height also happens on osx ... its different from start to start...

@elupus

This comment has been minimized.

Copy link
Member

commented Sep 5, 2012

It should be fixed now.

@elupus

This comment has been minimized.

Copy link
Member

commented Sep 5, 2012

When windows builds properly again, somebody might want to remove the
duplicate m_flags variable in that or rename the m_iFlags to m_flags
in all the other renderers.

@theuni

This comment has been minimized.

Copy link
Member

commented on configure.in in 6b37a4c Sep 20, 2012

@huceke this breaks other arm builds.

ffmpeg should be figuring out which arm instructions to use based on the cpu it's provided with (we already pass that in). We'll need to revert this unless you can give an example of something that's not detected correctly.

This comment has been minimized.

Copy link
Contributor Author

replied Sep 21, 2012

With arm flags :

grep ARM lib/ffmpeg/config.h

define ARCH_ARM 1

define HAVE_ARMV5TE 1

define HAVE_ARMV6 1

define HAVE_ARMV6T2 0

define HAVE_ARMVFP 1

Without arm flags :

grep ARM lib/ffmpeg/config.h

define ARCH_ARM 1

define HAVE_ARMV5TE 1

define HAVE_ARMV6 1

define HAVE_ARMV6T2 0

define HAVE_ARMVFP 1

So i assume it should be save for the PI to revert the arm configure flags.

Please leave use_hardcoded_tables alone. This is needed on the PI. Without hardcoded tables ffmpeg crashes on the PI.

This comment has been minimized.

Copy link
Member

replied Sep 21, 2012

Perfect, thanks.

This comment has been minimized.

Copy link
Member

replied Sep 21, 2012

friendly reminder here, arm flags are still there and because of that we can't play stuff on android now ( http://pastebin.com/EkJDJRX8 )
removing them fix that on android, but I would like someone who actually know what he's doing to look at it ;)

@ampedandwired

This comment has been minimized.

Copy link

commented on d11a167 Jan 20, 2013

Hi huceke, it seems this change has caused some playback problems for my Rdio plugin in Frodo.
Forum discussion: http://forum.xbmc.org/showthread.php?tid=152538&pid=1304505
Trac issue: http://trac.xbmc.org/ticket/13864

It seems that with this change PAPlayer now handles my rtmp stream, and it fails with "Unable to Init codec". Just trying to understand the change and how I can get my plugin working again? Are you able to provide any insight?

This comment has been minimized.

Copy link
Contributor

replied Jan 20, 2013

@huceke, I'm working on a fix :) stay tuned.

@Rechi Rechi referenced this pull request Feb 15, 2018
4 of 10 tasks complete
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
You can’t perform that action at this time.