New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PVR] Fix channel OSD dialog channel preselection. #12823

Merged
merged 1 commit into from Sep 24, 2017

Conversation

Projects
None yet
2 participants
@ksooo
Member

ksooo commented Sep 22, 2017

This fixes a problem reported in the forum: https://forum.kodi.tv/showthread.php?tid=298462&pid=2649281#pid2649281 ff

As channel switching is asynchronous, the currently playing channel group cannot be obtained safely directly after triggering the channel switch. If channel switching takes some time, there will be not yet a new playing channel group. Furthermore, resetting m_group in CGUIDialogPVRChannelsOSD::GotoChannel is not needed at all, as the new channel will always be from the same group as the old channel.

OTOH, m_group must be set when an actual channel group switch occurs in CGUIDialogPVRChannelsOSD::OnAction. This was missing.

@xhaggi for review?

@MilhouseVH this needs to be runtime tested by the bug reporters. Can you please include this PR in your next build?

@ksooo ksooo added this to the L 18.0-alpha1 milestone Sep 22, 2017

@ksooo ksooo requested a review from xhaggi Sep 22, 2017

@ksooo

This comment has been minimized.

Show comment
Hide comment
@ksooo

ksooo Sep 24, 2017

Member

Fix has been confirmed working by the bug reporter.

Member

ksooo commented Sep 24, 2017

Fix has been confirmed working by the bug reporter.

@ksooo ksooo merged commit 1eac449 into xbmc:master Sep 24, 2017

1 check passed

default You're awesome. Have a cookie
Details
// next OnInitWindow will set the group which is then selceted
m_group.reset();

This comment has been minimized.

@xhaggi

xhaggi Sep 24, 2017

Member

Sorry for the late response, on holiday atm. Minor typo in this line. Rest looks good.

@xhaggi

xhaggi Sep 24, 2017

Member

Sorry for the late response, on holiday atm. Minor typo in this line. Rest looks good.

This comment has been minimized.

@ksooo

ksooo Sep 24, 2017

Member

oops.

@ksooo

ksooo Sep 24, 2017

Member

oops.

@ksooo ksooo deleted the ksooo:pvr-fix-channel-osd-dialog-selection branch Sep 24, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment