Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

VideoPlayer: expose stereo mdoe to dataCache #12829

Merged
merged 2 commits into from Oct 2, 2017

Conversation

@FernetMenta
Copy link
Member

commented Sep 24, 2017

@da-anda @popcornmix StereoscopicManager is broken. In order to fix it it needs to pull stereoMode from DataCacheCore

@FernetMenta

This comment has been minimized.

Copy link
Member Author

commented Sep 24, 2017

@popcornmix couls you please adapt OMXPlayer

@da-anda

This comment has been minimized.

Copy link
Member

commented Sep 24, 2017

thanks for the headsup. @popcornmix as I haven't touched any C++ in likely over a year, would you mind adjusting stereoscopic manager accordingly?

@FernetMenta as the stream info might not be available when the "playback started" message is fired by core (which stereoscopic manager listens too to inject it's logic), is there by now a better way to be notified about stream changes?

@FernetMenta

This comment has been minimized.

Copy link
Member Author

commented Sep 24, 2017

@da-anda StereoscopicManager has even been wrong in this regard. OnPlaybackStarted was fired when a new file was opened but not on every stream change.

@da-anda

This comment has been minimized.

Copy link
Member

commented Sep 24, 2017

well, it was the best non-intrusive way I could find back then. Are there better suited messages/signals around now? I stopped following the development over a year ago, when my worker thread got hold of a lock which is preventing my fun thread from filling the sparetime buffer, thus the buffer drained. Seems I have to refactor cMyLife application before it crashes

@FernetMenta

This comment has been minimized.

Copy link
Member Author

commented Sep 25, 2017

@da-anda currently you can only poll this info. What does StereoscopicsManager do when it detects a change?

@FernetMenta FernetMenta force-pushed the FernetMenta:stereo branch from 2026a8c to 5a41bac Oct 1, 2017
@FernetMenta FernetMenta merged commit 37e5b71 into xbmc:master Oct 2, 2017
1 check passed
1 check passed
default You're awesome. Have a cookie
Details
@FernetMenta FernetMenta deleted the FernetMenta:stereo branch Oct 2, 2017
@Rechi Rechi added this to the L 18.0-alpha1 milestone Oct 2, 2017
@da-anda

This comment has been minimized.

Copy link
Member

commented Oct 6, 2017

sorry for not responding earlier. IIRC, up until now, StereoscopicsManager checked on playback start of a file if it is a stereoscopic file or not, and depending on this information and the currently active rendering mode (disabled, monoscopic, some stereoscopic mode) and the users preferences (always switch between regular mode and stereoscopic on mixed playback // keep current mode // always use mode of video // ask using a dialog) it will set the desired stereoscopic mode in the graphicsContext. So it's mostly a class to handle user preferences and configure related components accordingly

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.