Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Already on GitHub? Sign in to your account

Windows: Create minidumps for threads terminated by exceptions #1285

Merged
merged 3 commits into from Sep 2, 2012

Conversation

Projects
None yet
2 participants
Member

wsoltys commented Aug 13, 2012

This is just a resurrection of #813. I had to move the writedump methods to XBApplicationEx.cpp because they wasn't caught in thread.cpp.
I've added quite some code duplication in XBApplicationEx.cpp because I didn't want to introduce new methods or goto's. Please comment if there's a better way.

Member

wsoltys commented Aug 15, 2012

@jimfcarroll I've added some minidumps to thread.cpp as CrystalP did: wsoltys/xbmc@fe6cc74 (somehow I can't see that yet in the pr). Do I still need the own catch routine there?

Member

jimfcarroll commented Aug 16, 2012

I tried to take a quick look but didn't get far enough to understand more than what you're trying to do. I should be able to take a closer look over the weekend.

Just so you know, when I was working with CrystalP I added the abstract Exception handling so that you could plug in logging (minidump, etc) in the LogThrowMessage of the Win32Exception. I never heard back from him as to whether that worked for him.

Member

wsoltys commented Aug 16, 2012

Thanks for looking into it. I forced a division by zero in a thread to test it but it was only caught in the default handler (...). After calling win32_exception::install_handler(); in CThread:action (see 1b436e6) it worked at least with the two catch's I've added.

Member

jimfcarroll commented Aug 18, 2012

I want to do the same thing. where is a good place for the divide by zero?

Member

wsoltys commented Aug 18, 2012

MP3Codec.cpp comment l60 and play a mp3 file :)

Member

wsoltys commented Aug 18, 2012

note that for debugging the catch's in xbapplicationex are ifdef out that the ide catches the exception.

Member

wsoltys commented Aug 18, 2012

okay, squashed and rebased with jcarrolls changes.

wsoltys added a commit that referenced this pull request Sep 2, 2012

Merge pull request #1285 from wsoltys/minidump
[WIN32] Create minidumps for threads terminated by exceptions

@wsoltys wsoltys merged commit c2b9d75 into xbmc:master Sep 2, 2012

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment