Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix black screen on Snes9x emulators when ROM is missing #12882

Merged
merged 1 commit into from Oct 6, 2017

Conversation

@garbear
Copy link
Member

commented Oct 4, 2017

I've identified a silent failure mode. When Snes9x can't open its ROM it reports success and the fullscreen window is shown, even though the game is not playing.

How Has This Been Tested?

Tested on Windows with the file on a disconnected network drive.

Types of change

  • Bug fix (non-breaking change which fixes an issue)
  • Improvement (non-breaking change which improves existing functionality)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
@Rechi

This comment has been minimized.

Copy link
Member

commented Oct 6, 2017

jenkins build this please

@garbear garbear merged commit d18acce into xbmc:master Oct 6, 2017
1 check passed
1 check passed
default You're awesome. Have a cookie
Details
@garbear garbear deleted the garbear:fix-snes9x branch Oct 6, 2017
@Rechi Rechi added this to the L 18.0-alpha1 milestone Oct 6, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.