Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Already on GitHub? Sign in to your account

StringUtils fixes #1289

Merged
merged 3 commits into from Oct 13, 2012

Conversation

Projects
None yet
2 participants
Member

Karlson2k commented Aug 14, 2012

Mostly cosmetics.

Member

jmarshallnz commented Aug 14, 2012

Please also add a test case for this to Test().

@Karlson2k: Did you get my PM on the forums?

Member

Karlson2k commented Aug 15, 2012

@jmarshallnz jmarshallnz was assigned Aug 26, 2012

Member

Karlson2k commented Aug 30, 2012

@jmarshallnz "Test" corrected.

Member

jmarshallnz commented Oct 2, 2012

@Karlson2k We now have a unit testing framework for tests. Mind moving the tests into that?

Member

Karlson2k commented Oct 2, 2012

@jmarshallnz Done + rebase and squash

Member

jmarshallnz commented Oct 2, 2012

Thanks. Is there a use case where a string was passed to TimeStringToSeconds with spaces, tabs or new lines in front or at end?

Member

Karlson2k commented Oct 2, 2012

If raw result of some regex is passed as input.

Member

jmarshallnz commented Oct 2, 2012

Does this actually happen, or is it a theoretical issue? I don't mind either way, but it's nice to know if it actually fixes a current issue.

Member

Karlson2k commented Oct 2, 2012

Cleaning of input currently don't fix anything. It's just precaution.

@jmarshallnz jmarshallnz added a commit that referenced this pull request Oct 13, 2012

@jmarshallnz jmarshallnz Merge pull request #1289 from Karlson2k/String_Utils_Fixes
StringUtils fixes
f18393b

@jmarshallnz jmarshallnz merged commit f18393b into xbmc:master Oct 13, 2012

@Karlson2k Karlson2k deleted the Karlson2k:String_Utils_Fixes branch Oct 15, 2013

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment