Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[cmake] support building with ninja on posix platforms #12936

Merged
merged 2 commits into from Nov 3, 2017

Conversation

@wsnipex
Copy link
Member

commented Oct 19, 2017

2nd try for #12920

@MilhouseVH could you try this and include it in your nightlies?

@MilhouseVH

This comment has been minimized.

Copy link
Contributor

commented Oct 19, 2017

This looks good now, it will be in tonight's builds. Thanks.

@Rechi

This comment has been minimized.

Copy link
Member

commented Oct 21, 2017

jenkins build this please

@MilhouseVH

This comment has been minimized.

Copy link
Contributor

commented Oct 23, 2017

Just one problem...

Testing on Ubuntu with latest kodi master (75bddb4) + PR12936:

neil@nm-linux:~/projects$ curl --header 'Content-Type: application/json' --data-binary '{"jsonrpc": "2.0", "method": "JSONRPC.Version", "id": "libVersion"}' 'http://localhost:8080/jsonrpc';echo
{"id":"libVersion","jsonrpc":"2.0","result":{"version":{"major":0,"minor":3,"patch":0}}}

The JSON version is reported as 0.3.0

Without this PR, the JSON version reported by Kodi on Ubuntu is 8.3.0.

@MilhouseVH MilhouseVH referenced this pull request Nov 1, 2017

@wsnipex wsnipex force-pushed the wsnipex:cmake-fix-json branch from 2d45e30 to 66b1ccd Nov 1, 2017

@wsnipex

This comment has been minimized.

Copy link
Member Author

commented Nov 1, 2017

should be fixed now, thanks for testing

@MilhouseVH

This comment has been minimized.

Copy link
Contributor

commented Nov 1, 2017

It builds OK on Ubuntu (and the version is correct), but when building for LibreELEC (and ninja) I'm getting this build failure: http://sprunge.us/OWHW

@MilhouseVH

This comment has been minimized.

Copy link
Contributor

commented Nov 1, 2017

The above build failure is fixed with this addition in LibreELEC: LibreELEC/LibreELEC.tv@1264fd3

Ubuntu and LibreELEC have now built, and the JSON version is being returned as 8.3.0 - this PR seems to be OK now, many thanks!

@wsnipex wsnipex force-pushed the wsnipex:cmake-fix-json branch from 66b1ccd to 1cea4c7 Nov 1, 2017

@wsnipex

This comment has been minimized.

Copy link
Member Author

commented Nov 1, 2017

added a fix for building jsonschemabuilder when c++11 is not default, so the LE workaround shouldn't be needed anymore.

@MilhouseVH

This comment has been minimized.

Copy link
Contributor

commented Nov 1, 2017

Thanks - LE commit dropped.

@wsnipex

This comment has been minimized.

Copy link
Member Author

commented Nov 2, 2017

jenkins build this please

@afedchin

This comment has been minimized.

Copy link
Member

commented Nov 2, 2017

win-arm-uwp build error isn't related. will be fine on next build

@wsnipex wsnipex merged commit a09bb93 into xbmc:master Nov 3, 2017

1 check failed

default Sorry, building this PR failed. Please check the logs for the errors.
Details

@Rechi Rechi added this to the L 18.0-alpha1 milestone Nov 3, 2017

@MartijnKaijser

This comment has been minimized.

This comment has been minimized.

Copy link
Member Author

replied Nov 12, 2017

right. I don't think we should fix it though, since we will soon require C++14 anyway:
#13034

This comment has been minimized.

Copy link
Member

replied Nov 12, 2017

Can you comment on the ticket?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
5 participants
You can’t perform that action at this time.