configure switch for ssh support #1316

1 commit merged into from Oct 7, 2012


None yet

3 participants

Team Kodi member

As there were discussions on the forum and IRC about missing SFTP support in ubuntu packages I found that configure silently disables ssh sftp support if libssh is missing.
This enables a switch for libssh with the default being enabled, which is a change in behaviour(current is auto). The reason being to let packagers know, that they are - probably unknowingly - building without ssh support.

Team Kodi member

sorry about the hunk. also added to final_message

Team Kodi member

@theuni I squashed the old commits into this one. Since I'm kind of a git noob, your comments got lost, sorry about that.

Team Kodi member

no worries, that's normal when you squash down.. you did it just right.

Thanks for making those changes. Looks good to me for September window.

Team Kodi member

We missed the September window. Scheduled for October.

Team Kodi member

is there still something to be changed from my side?

@ghost ghost merged commit 7cd7792 into xbmc:master Oct 7, 2012
@LongChair LongChair added a commit to plexinc/plex-home-theater-public that referenced this pull request Nov 21, 2014
@LongChair LongChair Fix Adopt similar transcoding logic as other clients have #1316
 - Adds a new `Force Transcode Setting`
 - Unless this setting is active, transcoding quality will now act as a threshold to trigger transcoding.
 - Whatever is below won't get transcoded.
 - Whetever is above will be transcoded to the requested quality
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment