Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Estuary] don't hide scroll buttons in textviewer #13166

Merged
merged 1 commit into from Dec 17, 2017

Conversation

@ronie
Copy link
Member

commented Dec 11, 2017

@phil65

This comment has been minimized.

Copy link
Member

commented Dec 12, 2017

hmm does container.hasprevious / container.hasnext work correctly for textboxes?
They seem to be implemented. ( https://github.com/xbmc/xbmc/blob/master/xbmc/guilib/GUITextBox.cpp#L435-L438 )

@ronie

This comment has been minimized.

Copy link
Member Author

commented Dec 12, 2017

i just tested it. while it does work for textboxes, it has the exact same issue.

@phil65

This comment has been minimized.

Copy link
Member

commented Dec 14, 2017

ok, thx.
My favourite would be if someone could take a look at that core bug then.... if noone has time to tacke that then I am fine with merging this for now.

@MartijnKaijser MartijnKaijser added this to the L 18.0-alpha1 milestone Dec 17, 2017
@MartijnKaijser MartijnKaijser merged commit 1bc2d58 into xbmc:master Dec 17, 2017
@ronie ronie deleted the ronie:estuary-textviewer branch May 7, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.