WinSystems: Use EqualsNoCase which is wanted for identifying sinks #13171
Conversation
|
Added the others - mmh - that code duplication really sucks :-) |
fritsch
changed the title
|
Better would be |
|
@garbear thx very much - yes! That's better. |
fritsch
changed the title
|
jenkins build and merge |
|
thanks. |
Rechi
added
Component: Audio
Type: Fix
|
After this PR, most audio devices are no longer listed/available in Linux. Kodi on Ubuntu 17.10 (Radeon HD graphics card): Without PR: With PR: Same with LibreELEC (Skylake NUC): |
|
I don't see an issue here. With this PR audio defaults to PulseAudio (which is correct), before it was using ALSA. If you want to use ALSA, you have to set AE_SINK=ALSA |
|
So Kodi was using ALSA before, which is the mistake that this PR corrects? If so no problem, but this seems to be a change in default behaviour (whether intentional or not). |
|
The default behaviour before the factory cleanup was trying PA first. |
|
Not sure what Kodi was (or should have) been doing, but I'm building Kodi for Ubuntu without any build options (ie. everything default, no additional patches or custom configuration) and until this PR Kodi would find all my audio devices, now after this PR it doesn't. |
|
Maybe it needs |
this is not correct. It does find the PA devices. |
|
See pictures I posted. There is unquestionably a change in default behaviour caused by this PR. |
|
anyway, this has ever been intended behaviour. |
|
@MilhouseVH yes - finding ONLY pulseaudio devices is exactly what we want. This is the behaviour e.g. v17 and all other v18 builds have before the "factory changes". Reason is, that pulse and ALSA provide the same devices but in different form. As you see in your screenshot, before this fix here you did NOT have any PULSE devices at all (only the ALSA wrappers). Btw. don't mix that with LibreELEC - here PULSE / ALSA is patched so that the BT pulse device is added on top. |
|
Thanks @fritsch, my concern was only that there seemed to be a change in default behaviour, but as I don't remember how Kodi 17 behaved it sounds like this is restoring the original default behaviour! I guess for Ubuntu I'll now set the Currently in LE we've dropped the ALSA/Pulse patch due to these recent AE changes (last couple of releases) so LE currently behaves the same as plain Linux. We'll reintroduce the patch shortly, however, which hopefully restores the behaviour we require. |
This only makes sense if you disable PA while running Kodi. If PA is running ALSA gets routed through the PA server which is crap. |
|
That's only true for the default / pulse device, which is a pseudo alsa device - for an exclusive device the big fight for who owns the device starts and will end bad :-). Imagine we suspend the device, cause of idleing - pulseaudio takes it - and boom, we don't get it back. Or on startup pulse already has it, we cannot open it and so on. But I am also interested why you need AE_SINK=ALSA on a Desktop |
|
That's another reason why we don't register ALSA when PA is active. |
I possibly don't. I don't use this Ubuntu system for Kodi very much (it's my build system) and simply noticed the change of behaviour (which apparently only occurred in the last few days) and because audio devices appeared then disappeared I was no longer sure how my audio had been set up previously (last time I needed to change it was a while ago). So, mucho confusion on my part. PulseAudio seems to be working. I could have sworn in the past I had the HDMI devices listed too, but obviously not. |
|
No problem. Thanks for reporting back. |
|
not sure if there is "no" problem.
So something has changed that does not like my setup :-/ any hints? |
|
Hint is: No debuglog no issue - and the forum is the place to report ... this is a devspace. On topic: We seem to miss system.h include and therefore the ifdefs end up negative. |
|
Fix is coming here: #13181 - what a side effect of other cleanup :-) quite fragile our system. |
evil and madness will happen