Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[linux] move platform dependent code to xbmc/platform #13179

Merged
merged 4 commits into from Dec 15, 2017

Conversation

@lrusak
Copy link
Contributor

commented Dec 12, 2017

@FernetMenta is this what you had in mind?

@FernetMenta

This comment has been minimized.

Copy link
Member

commented Dec 12, 2017

Great! Now we also got a good location for OptionalsReg

@lrusak

This comment has been minimized.

Copy link
Contributor Author

commented Dec 12, 2017

jenkins build this please

@lrusak

This comment has been minimized.

Copy link
Contributor Author

commented Dec 13, 2017

Jenkins seems happy, I'm not sure about the OSX build failure (seems unrelated)

@lrusak

This comment has been minimized.

Copy link
Contributor Author

commented Dec 13, 2017

@FernetMenta are you happy with this?

@FernetMenta

This comment has been minimized.

Copy link
Member

commented Dec 13, 2017

@lrusak looks good imo. thanks!

lrusak added 4 commits Dec 12, 2017
@lrusak lrusak force-pushed the lrusak:linux-platform branch from 0245e18 to 15895ea Dec 13, 2017
@lrusak

This comment has been minimized.

Copy link
Contributor Author

commented Dec 13, 2017

jenkins build this please

1 similar comment
@lrusak

This comment has been minimized.

Copy link
Contributor Author

commented Dec 14, 2017

jenkins build this please

@lrusak

This comment has been minimized.

Copy link
Contributor Author

commented Dec 14, 2017

@FernetMenta good to merge?

@FernetMenta

This comment has been minimized.

Copy link
Member

commented Dec 14, 2017

I think so :)

@lrusak lrusak merged commit 4fab351 into xbmc:master Dec 15, 2017
1 check failed
1 check failed
default Sorry, building this PR failed. Please check the logs for the errors.
Details
@Rechi Rechi added this to the L 18.0-alpha1 milestone Dec 15, 2017
tomlohave added a commit to OpenBricks/xbmc that referenced this pull request Dec 15, 2017
Rechi added a commit that referenced this pull request Dec 15, 2017
Update Makefile.am after #13179
gentoo-bot pushed a commit to gentoo/gentoo that referenced this pull request Dec 15, 2017
See xbmc/xbmc#13179

Package-Manager: Portage-2.3.18, Repoman-2.3.6
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.