New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[PVR] Make shared channel selection optional. #13237
Conversation
What happens if you disable the option and open a window if there is no playing channel? And what bothered the users?
I've to ask because why should the generell sync of the selected channel be an issue for someone? EDIT: and should we think about an alternate option to this one. Selection for channel lists
|
They don't understand the logics and want it simple stupid. And I'm with them. |
They don't understand that the channel selected in channel list will be the same in guide window and vice versa if opened up? |
Yes, they want the behavior every settop box has - nothing semi cute... |
Maybe they understand this, but they do not want it. Even the guy who originally requested this feature (forgot his name) meanwhile stated in the forum that this is not a cool feature (for him) any more. |
Does it mean a settop box will have different selected channels in each view? |
Come on! What is goal of this discussion? Let's make this a setting and everybody is happy. Obviously many users don't want the current behavior and some like it. There is no right and wrong here. This is a clear indicator for a setting. |
Discussions are part of pull requests and should give us the opportunity to think about the changes someone what to merge. My discussion does not mean I disagree with it in general. Please don't get me wrong.
As you only select the playing channel in case the setting is false, and if no playing channel is found, nothing is changed in behavior, I'm not sure if we should name the setting like you did in this PR. Please make it clear to the user that he enable auto-select the playing channel entry in the channel list if he open the window/dialog. |
#empty string with id 36214 | ||
#: system/settings/settings.xml | ||
msgctxt "#36214" | ||
msgid "Share the selected channel across windows and dialogs. If enabled, the channel previously selected in a window or dialog will be pre-selected when opening any window containing a channel list. If disabled and there is a playing channel, the playing channel will be pre-selected when openeing a window or dialog containing a channel list." |
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
That's part of the help text. I tried my best to explain this there. I like the naming of the setting exactly like it is. |
Nobody is complaining about the selection when nothing is playing. People complain about what is selected when something is playing. :-) If you want I can easily change the behavior to vreturn empty path if nothing is playing and the setting is off, which leads in selecting the first list entry. |
No pls do not change the synced selection between channel lists, this should be the default if no playing channel is found. It would be nice if we could find a better wording here. "Shared channel selection" sounds wrong to me, if that is our default if no playing channel is found. Why not the other way around, like "Select playing channel in lists", default false. |
224c47b
to
72c707a
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes thanks ;)
It has been requested in the forum many times to make the "shared channel selection feature" optional. Here we go.
Runtime-tested on macOS, latest Kodi master.
@xhaggi (the biggest fan of the shared channel selection feature) mind taking a look...