Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PVR][Estuary] PVRInfoPanel cleanup. #13255

Merged
merged 2 commits into from Dec 27, 2017
Merged

Conversation

@ksooo
Copy link
Member

ksooo commented Dec 26, 2017

Cleanup PVRInfoPanel and refactor channels, recordings, timers, timer rules and search window to use PVRInfoPanal - for consistent and improved user experience.

Before:
screenshot003
screenshot004
screenshot005

After:
screenshot000
screenshot001
screenshot002

@ronie for review?

@ksooo ksooo added this to the L 18.0-alpha1 milestone Dec 26, 2017
@ksooo ksooo requested a review from ronie Dec 26, 2017
@ksooo ksooo force-pushed the ksooo:pvr-estuary-pvrinfopanel branch from a0590fc to 911f0f2 Dec 26, 2017
@ksooo ksooo force-pushed the ksooo:pvr-estuary-pvrinfopanel branch from 911f0f2 to 102779d Dec 26, 2017
@da-anda

This comment has been minimized.

Copy link
Member

da-anda commented Dec 27, 2017

I think I'd personally move the thumb/icon to the right, like it was on most of the older views. That way we also wouldn't need a default thumb for everything that might not necessarily make sense (visually). But that's just my taste.

@MartijnKaijser

This comment has been minimized.

Copy link
Member

MartijnKaijser commented Dec 27, 2017

fyi I don't have any thumbs added so i would get the default thumb everywhere? I'm surely not alone as adding them isn't noob friendly.

@ksooo

This comment has been minimized.

Copy link
Member Author

ksooo commented Dec 27, 2017

This PR is about consistency and code reusage. Improvements are for another round. No discussion about left/right, larger/smaller, nose dripping, unwanted Christmas gifts,... please. ;-)

I tried channel logos on the right and it looked ugly (imo). So I decided to put them on the left. Default icon on the left still looks better than lots of empty space on the right.

@ronie
ronie approved these changes Dec 27, 2017
Copy link
Member

ronie left a comment

looks good to me

@ksooo ksooo merged commit d799240 into xbmc:master Dec 27, 2017
1 check passed
1 check passed
default You're awesome. Have a cookie
Details
@ksooo ksooo deleted the ksooo:pvr-estuary-pvrinfopanel branch Dec 30, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.