Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PVR] Remove unused action ACTION_PLAY, use ACTION_PLAYER_PLAY. #13272

merged 1 commit into from Dec 30, 2017


Copy link

commented Dec 30, 2017

ACTION_PLAY was not wired to button translator and thus actually dead code and in fact a duplicate to ACTION_PLAYER_PLAY. This PR removes ACTION_PLAY (which only occurred in PVR code) and replaces it with ACTION_PLAYER_PLAY. Immediate gain is that now the "play" button present on many remotes and keyboards starts playing the selected channel / recording in the respective PVR windows and dialogs.

@da-anda you suggested this change long time ago... ;-)

@xhaggi mind taking a look at the code change. It's straight forward.

@ksooo ksooo added this to the L 18.0-alpha1 milestone Dec 30, 2017
@ksooo ksooo requested a review from xhaggi Dec 30, 2017
xhaggi approved these changes Dec 30, 2017
Copy link

left a comment

Looks good

@ksooo ksooo merged commit fe1fba7 into xbmc:master Dec 30, 2017
1 check passed
1 check passed
default You're awesome. Have a cookie
@ksooo ksooo deleted the ksooo:pvr-action-player-play branch Dec 30, 2017

This comment has been minimized.

Copy link

commented Dec 31, 2017

@da-anda you suggested this change long time ago... ;-)

I did? Don't even remember :) But thanks 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
None yet
3 participants
You can’t perform that action at this time.