Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

settings: drop warning log, reduce log spam #13349

Merged
merged 1 commit into from Jan 13, 2018

Conversation

@FernetMenta
Copy link
Member

commented Jan 12, 2018

As discussed with @Montellese
Those warnings are meaningless. Option fillers can be registered on-demand. As we are moving away from having globals, other components will follow AE and register their option fillers after load of settngs. A debug log here would just create log spam.

@Montellese

This comment has been minimized.

Copy link
Member

commented Jan 12, 2018

I just noticed that there is no log message when loading the option filler on-the-fly fails. We should probably add that or we won't be able to recognize these mistakes from the log files.

@FernetMenta FernetMenta force-pushed the FernetMenta:warning branch from 3448ec1 to e3bb5ff Jan 12, 2018
@FernetMenta

This comment has been minimized.

Copy link
Member Author

commented Jan 12, 2018

@Montellese updated. please have a look if I did it right

return nullptr;
}

This comment has been minimized.

Copy link
@Montellese

Montellese Jan 12, 2018

Member

Looks unneeded.

This comment has been minimized.

Copy link
@FernetMenta

FernetMenta Jan 13, 2018

Author Member

leftover from testing. dropped this change now

@Montellese

This comment has been minimized.

Copy link
Member

commented Jan 12, 2018

Looks ok apart from the minor.

@FernetMenta FernetMenta force-pushed the FernetMenta:warning branch from e3bb5ff to 2a55e3f Jan 13, 2018
@FernetMenta

This comment has been minimized.

Copy link
Member Author

commented Jan 13, 2018

osx error unrelated

@FernetMenta FernetMenta merged commit 77452d7 into xbmc:master Jan 13, 2018
1 check failed
1 check failed
default Sorry, building this PR failed. Please check the logs for the errors.
Details
@FernetMenta FernetMenta deleted the FernetMenta:warning branch Jan 13, 2018
@Rechi Rechi added this to the L 18.0-alpha1 milestone Jan 13, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.