Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.Sign up
fix focus being lost when that was not intended #13359
see #13356 for description. The initial fix proposed there was symptomatic and somewhat invalid.
Motivation and Context
How Has This Been Tested?
Screenshots (if appropriate):
Types of change
not sure what you mean... Seems like the code before that had the issue too. That said it's an issue with only very rare negative effect. The screensaver reset and DPMS stuff gets called anyway inside OnAppCommand, it's only the mouse move action (ACTION_MOUSE_MOVE) that has a potential negative effect. I'm surprised we haven't seen more issues because of this.
Previous code was missing break but did a return, so it worked. Changed code removed the return but missed the fact that it made up for the missing break. Little surprised that it was not caught in review. Errors like these are hard to track down. I'll bet there are more opps like this lurking.