Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

paplayer: fix player times for cue sheets #13363

Merged
merged 1 commit into from Jan 14, 2018

Conversation

@FernetMenta
Copy link
Member

commented Jan 14, 2018

see title

@DaveTBlake

This comment has been minimized.

Copy link
Member

commented Jan 14, 2018

Thanks @FernetMenta testing confirms that this solves the track overrun regression (introduced early December ) I was seeing when the cue sheet index values had frames. e.g. INDEX 01 01:20:61.

Secondarily is also applies the replay gain for the first track to all the songs from the cuesheet in the playlist (I was oddly getting this for all but the last track). To get individual track replay gain applied the tracks have to be played individually, not flow one to another in the current playlist.

@FernetMenta

This comment has been minimized.

Copy link
Member Author

commented Jan 14, 2018

ReplayGain is a differetn story. And step after another :)

osx build error unrelated

@FernetMenta FernetMenta merged commit 732be44 into xbmc:master Jan 14, 2018

1 check failed

default Sorry, building this PR failed. Please check the logs for the errors.
Details

@Rechi Rechi added this to the L 18.0-alpha1 milestone Jan 14, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.