Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Application: Set volume after opening file #13372

Merged
merged 1 commit into from Jan 15, 2018

Conversation

popcornmix
Copy link
Member

Initial volume was broken in omxplayer after #13301

Description

Set volume/mute after player is opened.

Motivation and Context

See: https://forum.kodi.tv/showthread.php?tid=298461&pid=2690445#pid2690445

How Has This Been Tested?

Positive reports in Milhouse nightly builds

Screenshots (if appropriate):

Types of change

  • Bug fix (non-breaking change which fixes an issue)
  • Improvement (non-breaking change which improves existing functionality)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the Code guidelines of this project
  • My change requires a change to the documentation, either Doxygen or wiki
  • I have updated the documentation accordingly
  • I have read the CONTRIBUTING document
  • I have added tests to cover my change
  • All new and existing tests passed

Initial volume was broken in omxplayer after xbmc#13301
@popcornmix
Copy link
Member Author

jenkins build this please
Ping @FernetMenta

@FernetMenta
Copy link
Contributor

thanks for fixing it

@popcornmix popcornmix merged commit 7acb05f into xbmc:master Jan 15, 2018
@popcornmix popcornmix deleted the playervolfix branch January 15, 2018 16:19
@Rechi Rechi added Type: Fix non-breaking change which fixes an issue v18 Leia labels Jan 15, 2018
@Rechi Rechi added this to the L 18.0-alpha1 milestone Jan 15, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: Fix non-breaking change which fixes an issue v18 Leia
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants