New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PVR] Guide window: Fix crash when switching profiles and both old an… #13397

Merged
merged 1 commit into from Jan 20, 2018

Conversation

Projects
None yet
2 participants
@ksooo
Member

ksooo commented Jan 20, 2018

…d new profile have guide window set as startup window.

Channel group selector must be inited before base class OnWindowInit is called to init the pointer to the container control early enough (it changes during profile switch). Selection of the control must be restored after calling base class OnWindowInit, like before.

@xhaggi good to go?

[PVR] Guide window: Fix crash when switching profiles and both old an…
…d new profile have guide window set as startup window.

@ksooo ksooo added this to the L 18.0-alpha1 milestone Jan 20, 2018

@ksooo ksooo requested a review from xhaggi Jan 20, 2018

@xhaggi

xhaggi approved these changes Jan 20, 2018

Looks good

@ksooo

This comment has been minimized.

Member

ksooo commented Jan 20, 2018

Thanks, will merge when jenkins is happy.

@ksooo ksooo merged commit eb1301a into xbmc:master Jan 20, 2018

1 check passed

default You're awesome. Have a cookie
Details

@ksooo ksooo deleted the ksooo:pvr-fix-guide-window-crash branch Jan 20, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment