New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix segfault #13411

Merged
merged 2 commits into from Jan 23, 2018

Conversation

Projects
None yet
3 participants
@FernetMenta
Member

FernetMenta commented Jan 22, 2018

fixes segault introduced by #12213

@peak3d

This comment has been minimized.

Contributor

peak3d commented Jan 22, 2018

The message should only be called time by time (500ms is fine), so we should implement a timer action for this IMO.
Or, would be a post message ok if we leave it in ProcessSlow?

@FernetMenta

This comment has been minimized.

Member

FernetMenta commented Jan 22, 2018

  • manipulation of gui items is supposed to be done in FrameMove
  • if gui is not shown, a refresh message makes no sense
  • timer for processSlow is not necessarly a good fit for updating gui items

all arguments why process slow is the wrong place

@peak3d

This comment has been minimized.

Contributor

peak3d commented Jan 22, 2018

pls. wait with merge, simply moving into FrameMove will not lead to the expected behaviour.
Have to check here

@FernetMenta

This comment has been minimized.

Member

FernetMenta commented Jan 22, 2018

read the code, there is a 500ms timer

@@ -2687,6 +2687,12 @@ void CApplication::FrameMove(bool processEvents, bool processGUI)
m_skipGuiRender = true;
#endif
if (g_advancedSettings.m_guiSmartRedraw && m_guiRefreshTimer.IsTimePast())

This comment has been minimized.

@peak3d

peak3d Jan 22, 2018

Contributor

Brackets about bit comparision missing
Nvm, misread something :-)

This comment has been minimized.

@Rechi

Rechi Jan 22, 2018

Member

no brackets missing here, this is just a boolean and operation

@peak3d

This comment has been minimized.

Contributor

peak3d commented Jan 22, 2018

I'm not sure if FrameMove is really called if GUI has nothing to do, thats the thing I wanted to test.
nevertheless thanx for the timer!

Edit: seems fine, thx!

@FernetMenta

This comment has been minimized.

Member

FernetMenta commented Jan 22, 2018

I'm not sure if FrameMove is really called if GUI has nothing to do

I am

@FernetMenta FernetMenta merged commit 9015b24 into xbmc:master Jan 23, 2018

1 check failed

default Sorry, building this PR failed. Please check the logs for the errors.
Details

@FernetMenta FernetMenta deleted the FernetMenta:segfault branch Jan 23, 2018

@Rechi Rechi added this to the L 18.0-alpha1 milestone Jan 23, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment