New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[depends] gnutls: don't use getentropy on darwin systems #13479

Merged
merged 1 commit into from Feb 4, 2018

Conversation

Projects
None yet
2 participants
@Rechi
Member

Rechi commented Feb 4, 2018

Motivation and Context

Kodi on iOS crashes, becausegetentropy symbol can't be found.

How Has This Been Tested?

runtime tested on iOS

Types of change

  • Bug fix (non-breaking change which fixes an issue)
  • Improvement (non-breaking change which improves existing functionality)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the Code guidelines of this project
  • My change requires a change to the documentation, either Doxygen or wiki
  • I have updated the documentation accordingly
  • I have read the CONTRIBUTING document
  • I have added tests to cover my change
  • All new and existing tests passed

@Rechi Rechi added this to the L 18.0-alpha1 milestone Feb 4, 2018

@Rechi Rechi requested a review from Memphiz Feb 4, 2018

@Memphiz

This comment has been minimized.

Member

Memphiz commented Feb 4, 2018

How so - related to the SDK/deployment target bump? Maybe gnutls doesn‘t properly obey the deployment target?

@Memphiz

Memphiz approved these changes Feb 4, 2018

Well fine by me - Any idea why the former patch didn‘t work here?

@Rechi

This comment has been minimized.

Member

Rechi commented Feb 4, 2018

-miphoneos-version-min=9.0 is correctly passed to the configure link test, but it passed with an implicit declaration of function 'getentropy' warning.

I don't know why it did work before, but I know the reason why it doesn't work now. configure creates Makefile from Makefile.am which already has a HAVE_GETENTROPY check. So the sed command is too late for that Makefile.

@Rechi Rechi merged commit 331db10 into xbmc:master Feb 4, 2018

1 check passed

default You're awesome. Have a cookie
Details

@Rechi Rechi deleted the Rechi:darwinGetentropy branch Feb 4, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment