Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added: option to stick 'add source' on top in listings #13546

Merged
merged 1 commit into from Feb 28, 2018

Conversation

@notspiff
Copy link
Contributor

commented Feb 14, 2018

Analogous to the option to put the 'all' items in library listings on top/bottom.

@ksooo

This comment has been minimized.

Copy link
Member

commented Feb 14, 2018

PVR windows, like channel window, epg window, are all derived from CGUIMediaWindow and for sure for those windows Add source makes no sense. How can CGUIWindowPVRBase be changed so that "Add source" will never appear for PVR windows?

@notspiff

This comment has been minimized.

Copy link
Contributor Author

commented Feb 14, 2018

unrelated to this as such. that's controlled by the view state class, CGUIViewState::DisableAddsourceButtons()

@notspiff notspiff force-pushed the notspiff:add_source_on_top branch from a0c1c12 to 74c1f1e Feb 14, 2018

@notspiff

This comment has been minimized.

Copy link
Contributor Author

commented Feb 28, 2018

2 weeks no comments. going in.

@notspiff notspiff merged commit 23ad481 into xbmc:master Feb 28, 2018

1 check passed

default You're awesome. Have a cookie
Details

@notspiff notspiff deleted the notspiff:add_source_on_top branch Feb 28, 2018

@Rechi Rechi added this to the L 18.0-alpha1 milestone Feb 28, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.