Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

extend aarch64 pattern in .gitignore #13580

Merged
merged 1 commit into from Feb 25, 2018

Conversation

@peak3d
Copy link
Contributor

commented Feb 24, 2018

Description

depend buid folders are currently not ignored due to recent changes in path names (-release / -debug)
This PR fixes search pattern in .gitinore

Types of change

  • Bug fix (non-breaking change which fixes an issue)
  • Improvement (non-breaking change which improves existing functionality)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
@peak3d peak3d requested a review from Rechi Feb 24, 2018
@peak3d peak3d added this to the L 18.0-alpha1 milestone Feb 24, 2018
@garbear

This comment has been minimized.

Copy link
Member

commented Feb 24, 2018

I also have an abundance of armv7a-cros-linux-gnueabi-release folders

@peak3d

This comment has been minimized.

Copy link
Contributor Author

commented Feb 24, 2018

ok, then let me check the others too

@Rechi

This comment has been minimized.

Copy link
Member

commented Feb 25, 2018

@peak3d most of the platform build directory excludes can be found in the following file

/target/*/x86_64-linux-gnu-*/*
/target/*/armeabi-v7a-*/*
/target/*/arm-linux-gnueabihf-*/*
/target/*/arm-linux-androideabi-*/*
/target/*/arm-linux-gnueabi-*/*
/target/*/macosx*.*_x86_64-target-*/
/target/*/macosx*.*_x86_64-target-*/*
/target/*/macosx*.*_i386-target-*/
/target/*/macosx*.*_i386-target-*/*
/target/*/iphoneos*.*_arm*-target-*/
/target/*/iphoneos*.*_arm*-target-*/*
/target/*/iphonesimulator*.*_i386*-target-*/
/target/*/iphonesimulator*.*_i386*-target-*/*
/target/*/iphonesimulator*.*_x86_64*-target-*/
/target/*/iphonesimulator*.*_x86_64*-target-*/*
/target/*/appletvos*.*_arm64*-target-*/
/target/*/appletvos*.*_arm64*-target-*/*
/target/*/appletvsimulator*.*_x86_64*-target-*/
/target/*/appletvsimulator*.*_x86_64*-target-*/*

Only you added aarch64-linux-gnu to .gitignore in root folder and I think that is also the reason why it wasn't updated.
Please move /target/*/aarch64-linux-gnu-*/* to tools/depends/.gitignore.
While you are at it can you also add /target/*/aarch64-linux-android-*/* and /target/*/i686-linux-android-*/*?
To ignore the folder @garbear mentioned change arm-linux-gnueabi-* to arm*-linux-gnueabi-*.

@peak3d

This comment has been minimized.

Copy link
Contributor Author

commented Feb 25, 2018

yes, will change today

@Rechi
Rechi approved these changes Feb 25, 2018
@peak3d peak3d merged commit 1ed83d8 into xbmc:master Feb 25, 2018
@peak3d peak3d deleted the peak3d:gi branch Feb 25, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.