Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Music]Fix FileItem::IsSamePath for albums and artists #13585

Merged
merged 1 commit into from Feb 28, 2018

Conversation

@DaveTBlake
Copy link
Member

DaveTBlake commented Feb 25, 2018

When MusicInfoTags are available comparing the DBId and the Type is a both more accurate and quicker test that two items are the same path.

Without it CFileItem::IsSamePath can return false matches if the file items are albums or artists i.e. library items that do not have a URL.

A similar fix was applied for video 4 years ago in #4345, this is a much belated catch-up for music.

a both more accurate and quicker test that two items are the same path.
@DaveTBlake DaveTBlake added this to the L 18.0-alpha1 milestone Feb 25, 2018
@DaveTBlake

This comment has been minimized.

Copy link
Member Author

DaveTBlake commented Feb 28, 2018

OSX build error is unreleated to this PR.
Going to merge as test fine, and just brings music in line with video 4 year late

@DaveTBlake DaveTBlake merged commit dd3caa3 into xbmc:master Feb 28, 2018
1 check failed
1 check failed
default Sorry, building this PR failed. Please check the logs for the errors.
Details
@DaveTBlake DaveTBlake deleted the DaveTBlake:IsSamePath branch Feb 28, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
1 participant
You can’t perform that action at this time.