Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[GBM] add better vendor EGL header compatibility #13643

Merged
merged 1 commit into from Mar 13, 2018

Conversation

@AreaScout
Copy link
Contributor

commented Mar 12, 2018

Description

It may be the case that your EGL headers shipped with your vendor image are not defining gbm_surface
but fbdev_window, mali_native_window or another unique name, while this is wrong for gbm enabled userspace libraries it could still be the case that other software still rely on fbdev_window and therefor the EGL headers may stay on different type defines

https://github.com/rockchip-linux/libmali/blob/rockchip/include/EGL/eglplatform.h#L73
https://github.com/rockchip-linux/libmali/blob/rockchip/include/FBDEV/eglplatform.h#L73

Motivation and Context

it would generate an error on compile time
error: cannot convert ‘gbm_surface*’ to ‘EGLNativeWindowType {aka fbdev_window*}’ in assignment

this small change fixes any possible compile error regardless of what type define is used

this is a duplicate of #13641, sorry i tried to make one commit but my branch got deleted

How Has This Been Tested?

Building on SBC gbm enabled devices

Types of change

  • Bug fix (non-breaking change which fixes an issue)
  • Improvement (non-breaking change which improves existing functionality)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the Code guidelines of this project
  • My change requires a change to the documentation, either Doxygen or wiki
  • I have updated the documentation accordingly
  • I have read the CONTRIBUTING document
  • I have added tests to cover my change
  • All new and existing tests passed

@AreaScout AreaScout changed the title [GBM] add better vendor EGL header compatibility [GBM] add better vendor EGL header compatibility [Linux] Mar 12, 2018

@AreaScout AreaScout changed the title [GBM] add better vendor EGL header compatibility [Linux] [GBM] add better vendor EGL header compatibility Mar 12, 2018

@lrusak lrusak merged commit 701da00 into xbmc:master Mar 13, 2018

1 check passed

default You're awesome. Have a cookie
Details
@lrusak

This comment has been minimized.

Copy link
Contributor

commented Mar 13, 2018

Thanks!!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.